Bug 149274 - Web Inspector: Inactive window may cause many layers to be created due to Dashboard opacity
Summary: Web Inspector: Inactive window may cause many layers to be created due to Das...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-17 11:13 PDT by Joseph Pecoraro
Modified: 2015-09-17 12:28 PDT (History)
8 users (show)

See Also:


Attachments
[IMAGE] Window Active (302.74 KB, image/png)
2015-09-17 11:16 PDT, Joseph Pecoraro
no flags Details
[IMAGE] Window Inactive (Issue) (284.84 KB, image/png)
2015-09-17 11:16 PDT, Joseph Pecoraro
no flags Details
[PATCH] Proposed Fix (1.69 KB, patch)
2015-09-17 11:32 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[IMAGE] With Fix (244.81 KB, image/png)
2015-09-17 11:32 PDT, Joseph Pecoraro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-17 11:13:48 PDT
* SUMMARY
Inactive window may cause many layers to be created due to Dashboard opacity.

See attached screenshots.

* STEPS TO REPRODUCE
1. Inspect a page
2. Pause
3. Make the window inactive
  => lots of layers
Comment 1 Radar WebKit Bug Importer 2015-09-17 11:14:08 PDT
<rdar://problem/22742333>
Comment 2 Joseph Pecoraro 2015-09-17 11:16:16 PDT
Created attachment 261401 [details]
[IMAGE] Window Active
Comment 3 Joseph Pecoraro 2015-09-17 11:16:35 PDT
Created attachment 261402 [details]
[IMAGE] Window Inactive (Issue)
Comment 4 Joseph Pecoraro 2015-09-17 11:18:34 PDT
The issue appears to be because of the opacity:

    body.latest-mac.window-inactive .toolbar .dashboard-container {
        opacity: 0.65;
        ...
    }

Which contains an animating element. This then uses a cascade of overlapping elements.

A possible workaround might be:

    body.latest-mac.window-inactive .toolbar .dashboard-container > *
        opacity: 0.65;
    }
Comment 5 Joseph Pecoraro 2015-09-17 11:27:49 PDT
> A possible workaround might be:

Naw that isn't good, it causes a few other issues and making it work starts being ugly.

An easy solution, stop the animation when the window is inactive!
Comment 6 Joseph Pecoraro 2015-09-17 11:32:17 PDT
Created attachment 261405 [details]
[PATCH] Proposed Fix
Comment 7 Joseph Pecoraro 2015-09-17 11:32:29 PDT
Created attachment 261406 [details]
[IMAGE] With Fix
Comment 8 Brian Burg 2015-09-17 11:42:09 PDT
Comment on attachment 261405 [details]
[PATCH] Proposed Fix

r=me
Comment 9 WebKit Commit Bot 2015-09-17 12:28:49 PDT
Comment on attachment 261405 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 261405

Committed r189923: <http://trac.webkit.org/changeset/189923>
Comment 10 WebKit Commit Bot 2015-09-17 12:28:52 PDT
All reviewed patches have been landed.  Closing bug.