Bug 149263 - [WebIDL] Add support for default parameter values
Summary: [WebIDL] Add support for default parameter values
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://heycam.github.io/webidl/#dfn-...
Keywords: InRadar, WebExposed
Depends on:
Blocks: 149331
  Show dependency treegraph
Reported: 2015-09-17 09:44 PDT by Chris Dumez
Modified: 2015-09-18 10:45 PDT (History)
8 users (show)

See Also:

Patch (23.75 KB, patch)
2015-09-17 10:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-17 09:44:28 PDT
Add support for default parameter values to our Web IDL parser / JS bindings generator. This will allow the bindings to convert undefined to the parameter's default value for optional parameters:

Initially, this will be used for document.createNodeIterator() / document.createTreeWalker()'s whatToShow parameter:

WebKit currently converts undefined to 0 in this case, even though it should be OxFFFFFFFF.
Comment 1 Chris Dumez 2015-09-17 09:45:07 PDT
Comment 2 Chris Dumez 2015-09-17 10:01:14 PDT
Created attachment 261394 [details]
Comment 3 WebKit Commit Bot 2015-09-17 18:48:38 PDT
Comment on attachment 261394 [details]

Clearing flags on attachment: 261394

Committed r189957: <http://trac.webkit.org/changeset/189957>
Comment 4 WebKit Commit Bot 2015-09-17 18:48:45 PDT
All reviewed patches have been landed.  Closing bug.