Bug 149260 – Remove XHR_TIMEOUT compilation guard

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[youenn fablet]

We should remove XHR_TIMEOUT compilation guard and rename didTimeout as didReachTimeout.

[youenn fablet]

Created attachment 261390 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 261390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261390&action=review

If we remove a compile time guard we should propose it on webkit-dev mailing list.

> Tools/Scripts/webkitperl/FeatureList.pm:-456
> -    { option => "xhr-timeout", desc => "Toggle XHR Timeout support",
> -      define => "ENABLE_XHR_TIMEOUT", default => (isEfl() || isGtk() || isAppleMacWebKit()), value => \$xhrTimeoutSupport },
> -

Please remove xhrTimeoutSupport variable in line 151.

[Benjamin Poulain]

Comment on attachment 261390 [details]
Patch

I don't know anything about this code but Alexey would have protested by now if there were issues :)

[youenn fablet]

Thanks for the reviews.

> I don't know anything about this code but Alexey would have protested by now
> if there were issues :)

I should have mentionned this was discussed as part of bug 98156.
ap agreed to remove it.

> Please remove xhrTimeoutSupport variable in line 151.

OK

[youenn fablet]

Created attachment 261609 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 261609 [details]
Patch for landing

Clearing flags on attachment: 261609

Committed r190025: <http://trac.webkit.org/changeset/190025>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.