Bug 149257 – Web Inspector: Option-Up doesn't increment certain attribute values

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 261386 [details]
[Animated GIF] Bug

Steps:
1. Go to http://n12v.dev/2-way-data-binding/
2. Inspect the first video, <video width="216" height="48" poster="/2-way-data-binding/temperature-converter.png">
3. Double click on "216"
4. Press Option-Up

Expected:
Value changes to "217", cursor stays where it was.

Actual:
Value changes to "217", cursor stays jumps to the beginning of the text field.

An error is thrown:

    IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value.
      setEnd - EditingSupport.js:267
      handleEditingResult - EditingSupport.js:267
      keyDownEventListener - EditingSupport.js:289

Note that modifying height on the very same element works as expected. Although, it causes the DOM path bar to blink.

[Radar WebKit Bug Importer]

<rdar://problem/22737768>

[Devin Rousso]

Created attachment 261486 [details]
Patch

[Nikita Vasilyev]

The patch works as expected and looks good to me!

In long term, we probably want to use CodeMirror for HTML elements & attributes editing.

(In reply to comment #0)
> Created attachment 261386 [details]
> [Animated GIF] Bug
> 
> Steps:
> 1. Go to http://n12v.dev/2-way-data-binding/

http://n12v.com/2-way-data-binding/

[Blaze Burg]

Comment on attachment 261486 [details]
Patch

r=me

This will need to be rebased before landing, it's a few weeks behind.

[Devin Rousso]

Created attachment 263758 [details]
Patch

Sorry for the delay.  Just got the build working on my laptop again :)

[WebKit Commit Bot]

Comment on attachment 263758 [details]
Patch

Clearing flags on attachment: 263758

Committed r191416: <http://trac.webkit.org/changeset/191416>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.