Bug 149255 - Delete some dead code
Summary: Delete some dead code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-17 02:39 PDT by Tim Horton
Modified: 2015-09-17 12:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.83 KB, patch)
2015-09-17 02:39 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (3.86 KB, patch)
2015-09-17 02:48 PDT, Tim Horton
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-09-17 02:39:20 PDT
Delete some dead code
Comment 1 Tim Horton 2015-09-17 02:39:41 PDT
Created attachment 261381 [details]
Patch
Comment 2 Tim Horton 2015-09-17 02:44:13 PDT
Comment on attachment 261381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261381&action=review

> Source/WebCore/platform/network/mac/CookieJarMac.mm:-145
> -    return false;

Oh, this is probably the what-happens-if-an-exception-is-thrown case (looking at what the exception blocking macros actually do). But I'm not sure why it's not a compilation error to not have this, because it seems like that would imply not having a return statement in the case that the exception is thrown...
Comment 3 Tim Horton 2015-09-17 02:48:11 PDT
Created attachment 261384 [details]
Patch
Comment 4 Tim Horton 2015-09-17 03:00:57 PDT
(In reply to comment #2)
> Comment on attachment 261381 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261381&action=review
> 
> > Source/WebCore/platform/network/mac/CookieJarMac.mm:-145
> > -    return false;
> 
> Oh, this is probably the what-happens-if-an-exception-is-thrown case
> (looking at what the exception blocking macros actually do). But I'm not
> sure why it's not a compilation error to not have this, because it seems
> like that would imply not having a return statement in the case that the
> exception is thrown...

Yeah... seems like that's just a missing warning (even -Weverything doesn't catch it in a silly test app).
Comment 5 Tim Horton 2015-09-17 12:00:54 PDT
http://trac.webkit.org/changeset/189921