Bug 149222 - webkit-patch rollout should not die when passed a unicode character in the message
Summary: webkit-patch rollout should not die when passed a unicode character in the me...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-16 10:42 PDT by BJ Burg
Modified: 2015-09-16 11:54 PDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-09-16 10:42:11 PDT 
This most often manifests as webkitbot refusing to do a rollout:

09:53 <alexchristensen> webkitbot: rollout 189851 189853 didn’t actually fix permissions issue
09:53 <webkitbot> alexchristensen: Preparing rollout for http://trac.webkit.org/changeset/189851 and http://trac.webkit.org/changeset/189853 ...
09:53 <webkitbot> Exception executing command: 'ascii' codec can't decode byte 0xe2 in position 4: ordinal not in range(128)

I added a parse test to irc_command_unittests.py to verify that the problem is not specific to the IRC bot's parser. It probably happens somewhere deeper in the rollout command.
Comment 1 Alex Christensen 2015-09-16 11:54:46 PDT 
I wondered why it failed.  I didn't see the ’ in didn’t.  That's annoying.