NEW149209
prepare-ChangeLog skips modified function if Git is configured with diff.mnemonicprefix 
https://bugs.webkit.org/show_bug.cgi?id=149209
Summary prepare-ChangeLog skips modified function if Git is configured with diff.mnem...
Ansh Shukla
Reported 2015-09-16 00:11:23 PDT
Users who have ``git config diff.mnemonicprefix=true`` will not have modified functions listed in their ChangeLog because diffHeaderFormat() is looking for headers of the form: ``return qr/^diff --git a\/.+ b\/(.+)$/ if isGit();``, but mnemonicprefix will change "a" and "b" to 'i', 'w', 'c', or 'o'. I think it's better to fix by changing the config for the diff command via option ``-c diff.mnemonicprefix=false``, but am open to other suggestions (e.g. changing the RegEx).
Attachments
Patch to fix by adding ``-c diff.mnemonicprefix=false`` to invocation. (2.72 KB, patch)
2015-09-16 00:18 PDT, Ansh Shukla 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ansh Shukla
Comment 1 2015-09-16 00:18:46 PDT
Created attachment 261300 [details] Patch to fix by adding ``-c diff.mnemonicprefix=false`` to invocation. This patch fixes the bug by ensuring that prepare-ChangeLog sets the expected configuration for ``git diff``.
Note You need to log in before you can comment on or make changes to this bug.