Bug 149203 - Fix asm.js errors in WebAssembly tests
Summary: Fix asm.js errors in WebAssembly tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 146064
  Show dependency treegraph
Reported: 2015-09-15 19:01 PDT by Sukolsak Sakshuwong
Modified: 2015-09-15 20:52 PDT (History)
1 user (show)

See Also:

Patch (11.35 KB, patch)
2015-09-15 19:04 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-15 19:01:48 PDT
Our WebAssembly implementation uses asm.js for testing. Using Firefox to parse asm.js reveals many errors that are not caught by pack-asmjs. For example,
- asm.js does not allow the use of the multiplication operator (*) to multiply two integers, because the result can be so large that some lower bits of precision are lost. Math.imul is used instead.
- an int variable must be coerced to either signed (via x|0) or unsigned (via x>>>0) before it's returned.
Comment 1 Sukolsak Sakshuwong 2015-09-15 19:04:47 PDT
Created attachment 261280 [details]
Comment 2 Geoffrey Garen 2015-09-15 20:38:30 PDT
Comment on attachment 261280 [details]

Comment 3 WebKit Commit Bot 2015-09-15 20:52:35 PDT
Comment on attachment 261280 [details]

Clearing flags on attachment: 261280

Committed r189844: <http://trac.webkit.org/changeset/189844>
Comment 4 WebKit Commit Bot 2015-09-15 20:52:37 PDT
All reviewed patches have been landed.  Closing bug.