Bug 149200 - Convert return values from JavaScript functions to the expected types in WebAssembly
Summary: Convert return values from JavaScript functions to the expected types in WebA...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 146064
  Show dependency treegraph
 
Reported: 2015-09-15 17:56 PDT by Sukolsak Sakshuwong
Modified: 2015-09-17 17:04 PDT (History)
7 users (show)

See Also:


Attachments
Patch (23.11 KB, patch)
2015-09-15 18:03 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff
Patch (23.07 KB, patch)
2015-09-15 18:07 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff
Patch (23.02 KB, patch)
2015-09-15 18:08 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff
Patch (19.40 KB, patch)
2015-09-17 02:57 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff
Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310 (19.65 KB, patch)
2015-09-17 16:14 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-15 17:56:04 PDT
Convert return values from JavaScript functions to the expected types in WebAssembly
Comment 1 Sukolsak Sakshuwong 2015-09-15 18:03:45 PDT
Created attachment 261274 [details]
Patch
Comment 2 Sukolsak Sakshuwong 2015-09-15 18:07:28 PDT
Created attachment 261276 [details]
Patch
Comment 3 Sukolsak Sakshuwong 2015-09-15 18:08:28 PDT
Created attachment 261277 [details]
Patch
Comment 4 Sukolsak Sakshuwong 2015-09-17 02:57:02 PDT
Created attachment 261385 [details]
Patch
Comment 5 Mark Lam 2015-09-17 10:27:25 PDT
Comment on attachment 261385 [details]
Patch

r=me
Comment 6 Saam Barati 2015-09-17 10:34:06 PDT
Comment on attachment 261385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261385&action=review

r=me with a comment

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:109
> +            // FIXME: No need to do type conversion if the caller is a WebAssembly function.

lets open a bug for this (if there isn't already one) and link it here.

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:984
> +        // FIXME: No need to do type conversion if the callee is a WebAssembly function.

Let's open a bug for this if there isn't one and link it here.
Comment 7 Sukolsak Sakshuwong 2015-09-17 16:14:17 PDT
Created attachment 261449 [details]
Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310
Comment 8 WebKit Commit Bot 2015-09-17 17:04:05 PDT
Comment on attachment 261449 [details]
Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310

Clearing flags on attachment: 261449

Committed r189946: <http://trac.webkit.org/changeset/189946>
Comment 9 WebKit Commit Bot 2015-09-17 17:04:09 PDT
All reviewed patches have been landed.  Closing bug.