RESOLVED FIXED 149197
REGRESSION(r188427): Web Inspector: Extra whitespace left behind in styles sidebar after clicking in and out 
https://bugs.webkit.org/show_bug.cgi?id=149197
Summary REGRESSION(r188427): Web Inspector: Extra whitespace left behind in styles si...
Joseph Pecoraro
Reported 2015-09-15 16:59:13 PDT
* SUMMARY Extra whitespace left behind in styles sidebar after clicking in and out. * STEPS TO REPRODUCE 1. Inspect <body> on <http://daringfireball.net> 2. Show Styles > Rules sidebar 3. Click in the first CSSStyleDeclarationTextEditor at the end of the line-height line => newline added to add a new property 4. Click out of the editor => expected newline to be removed, it remains * NOTES - Regressed with r188427 - bug 145679
Attachments
Patch (2.01 KB, patch)
2015-09-16 21:42 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-15 16:59:30 PDT
<rdar://problem/22711632>
Devin Rousso
Comment 2 2015-09-15 19:58:03 PDT
Just so I understand, we want to have it such that new CSS styles that are added follow the same indentation of existing CSS, but remove any leading/trailing whitespace and extra newlines in the middle. So it would format body { color: red; background-color: black; } into the style declaration with the following formatting: body { color: red; background-color: black; }
Joseph Pecoraro
Comment 3 2015-09-16 11:27:15 PDT
(In reply to comment #2) > Just so I understand, we want to have it such that new CSS styles that are > added follow the same indentation of existing CSS, but remove any > leading/trailing whitespace and extra newlines in the middle. So it would > format > > body { > color: red; > > background-color: black; > > } > > into the style declaration with the following formatting: > > body { > color: red; > background-color: black; > } Yep! In the sidebar I don't expect extra newlines in the middle if the editor is not focused. Preserving newlines in the actual StyleSheet's text would be nice, but I don't think we do that now so its fine if we reformat that a little.
Devin Rousso
Comment 4 2015-09-16 21:42:26 PDT
Created attachment 261365 [details] Patch
WebKit Commit Bot
Comment 5 2015-09-17 00:29:08 PDT
Comment on attachment 261365 [details] Patch Clearing flags on attachment: 261365 Committed r189909: <http://trac.webkit.org/changeset/189909>
WebKit Commit Bot
Comment 6 2015-09-17 00:29:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.