Element.getAttributeNS() should return null if the attribute does not exist, similarly to what Element.getAttribute() does: - https://dom.spec.whatwg.org/#element (both return a nullable DOMString). - https://dom.spec.whatwg.org/#dom-element-getattributens (step 2) Firefox and Chrome match the specification. WebKit returns an empty string for getAttributeNS() but null for getAttribute().
rdar://problem/22561011
Created attachment 261234 [details] Patch
Comment on attachment 261234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261234&action=review > Source/WebCore/dom/Element.idl:52 > + [ObjCLegacyUnnamedParameters, TreatReturnedNullStringAs=Null] DOMString getAttributeNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI, [Default=Undefined] optional DOMString localName); Can we split this into two lines? It's really long now.
Created attachment 261238 [details] Patch
Committed r189825: <http://trac.webkit.org/changeset/189825>
Comment on attachment 261234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261234&action=review >> Source/WebCore/dom/Element.idl:52 >> + [ObjCLegacyUnnamedParameters, TreatReturnedNullStringAs=Null] DOMString getAttributeNS([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI, [Default=Undefined] optional DOMString localName); > > Can we split this into two lines? It's really long now. I like it better long than split.