Bug 149173 – Web Inspector: command-click in NewTabContentView should open new tab without switching to it

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

This is how the home screen grids work in FF and Safari.

[Radar WebKit Bug Importer]

<rdar://problem/22705409>

[Blaze Burg]

Created attachment 261227 [details]
Proposed fix

[Joseph Pecoraro]

Comment on attachment 261227 [details]
Proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=261227&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:510
> +WebInspector.createNewTabWithType = function(tabType, options={})

In the one other place I think we have this right now, we have spaces. I still favor no spaces. Lets decide on IRC.

> Source/WebInspectorUI/UserInterface/Base/Main.js:520
> +    let insertionIndex = referencedView ? this.tabBar.tabBarItems.indexOf(referencedView.tabBarItem) : null;

Nit: I think `undefined` may be better than `null`. Null makes me think an object should go here, but it should be a number (or a default value), which null is not typically associated with.

> Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js:114
> +        let tabItemElements = Array.from(this.element.querySelectorAll("." + WebInspector.NewTabContentView.TabItemStyleClassName));

Nit: This could be a private function, since it is done in multiple places and is easy to get wrong.

[Blaze Burg]

Comment on attachment 261227 [details]
Proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=261227&action=review

>> Source/WebInspectorUI/UserInterface/Base/Main.js:520
>> +    let insertionIndex = referencedView ? this.tabBar.tabBarItems.indexOf(referencedView.tabBarItem) : null;
> 
> Nit: I think `undefined` may be better than `null`. Null makes me think an object should go here, but it should be a number (or a default value), which null is not typically associated with.

OK

[Blaze Burg]

Committed r189828: <http://trac.webkit.org/changeset/189828>