Bug 149163 - Switch AppleWin build to use CMake
Summary: Switch AppleWin build to use CMake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on: 149235
Blocks:
  Show dependency treegraph
 
Reported: 2015-09-15 08:54 PDT by Alex Christensen
Modified: 2015-09-17 14:27 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.14 KB, patch)
2015-09-15 10:19 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (10.11 KB, patch)
2015-09-15 13:52 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (15.66 KB, patch)
2015-09-17 13:37 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-09-15 08:54:58 PDT
Switch AppleWin build to use CMake
Comment 1 Alex Christensen 2015-09-15 10:19:27 PDT
Created attachment 261202 [details]
Patch
Comment 2 Brent Fulgham 2015-09-15 10:21:48 PDT
Comment on attachment 261202 [details]
Patch

Very nice!
Comment 3 Alex Christensen 2015-09-15 12:34:51 PDT
Landing this will break API tests because there are TestWTF, TestWebCore, and TestWebKit.  What should we do about this?
Comment 4 Alex Christensen 2015-09-15 13:52:10 PDT
Created attachment 261229 [details]
Patch
Comment 5 Brent Fulgham 2015-09-15 14:15:08 PDT
Comment on attachment 261229 [details]
Patch

r=me.
Comment 6 Alex Christensen 2015-09-17 13:37:06 PDT
Created attachment 261416 [details]
Patch
Comment 7 Alex Christensen 2015-09-17 13:38:56 PDT
Comment on attachment 261416 [details]
Patch

Latest patch has a few cygwin fixes that were not committed before.  Let's try this again.
Comment 8 WebKit Commit Bot 2015-09-17 14:27:19 PDT
Comment on attachment 261416 [details]
Patch

Clearing flags on attachment: 261416

Committed r189934: <http://trac.webkit.org/changeset/189934>
Comment 9 WebKit Commit Bot 2015-09-17 14:27:22 PDT
All reviewed patches have been landed.  Closing bug.