Bug 149152 - Move most IDB object encoding/decoding from WebKit2 to WebCore
Summary: Move most IDB object encoding/decoding from WebKit2 to WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-14 22:27 PDT by Brady Eidson
Modified: 2015-09-15 09:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (19.09 KB, patch)
2015-09-14 22:29 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 (21.82 KB, patch)
2015-09-15 08:53 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-09-14 22:27:08 PDT 
Move most IDB object encoding/decoding from WebKit2 to WebCore
Comment 1 Brady Eidson 2015-09-14 22:29:54 PDT 
Created attachment 261175 [details]
Patch v1

For an EWS run - Not including ChangeLogs because I have other changes locally that would cause this to not apply on EWS.

Definitely reviewable, though.
Comment 2 Brady Eidson 2015-09-15 08:53:38 PDT 
Created attachment 261193 [details]
Patch v2
Comment 3 Alex Christensen 2015-09-15 08:57:40 PDT 
Comment on attachment 261193 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=261193&action=review

r=me if ews passes

> Source/WebKit2/Shared/WebCoreArgumentCoders.h:405
>  template<> struct ArgumentCoder<WebCore::IDBGetResult> {

IDBGetResult feels left out :(
Comment 4 Brady Eidson 2015-09-15 09:11:59 PDT 
(In reply to comment #3)
> Comment on attachment 261193 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261193&action=review
> 
> r=me if ews passes
> 
> > Source/WebKit2/Shared/WebCoreArgumentCoders.h:405
> >  template<> struct ArgumentCoder<WebCore::IDBGetResult> {
> 
> IDBGetResult feels left out :(

It can't be moved right now because it uses DataReference which is WK2-only.

But good news - While resolving https://bugs.webkit.org/show_bug.cgi?id=149117, IDBGetResult will be going away entirely. :)
Comment 5 Brady Eidson 2015-09-15 09:34:02 PDT 
The EFL failure:

../../Source/WebCore/Modules/indexeddb/IDBKeyPath.h: In static member function 'static bool WebCore::IDBKeyPath::decode(Decoder&, WebCore::IDBKeyPath&) [with Decoder = IPC::ArgumentDecoder]':
../../Source/WebCore/Modules/indexeddb/IDBKeyPath.h:140:1: error: control reaches end of non-void function [-Werror=return-type]

...Even though all switch cases are accounted for. :(  Stupid compiler.

Will fix.
Comment 6 Brady Eidson 2015-09-15 09:36:47 PDT 
https://trac.webkit.org/changeset/189810