RESOLVED FIXED 149152
Move most IDB object encoding/decoding from WebKit2 to WebCore
https://bugs.webkit.org/show_bug.cgi?id=149152
Summary Move most IDB object encoding/decoding from WebKit2 to WebCore
Brady Eidson
Reported 2015-09-14 22:27:08 PDT
Move most IDB object encoding/decoding from WebKit2 to WebCore
Attachments
Patch v1 (19.09 KB, patch)
2015-09-14 22:29 PDT, Brady Eidson
no flags
Patch v2 (21.82 KB, patch)
2015-09-15 08:53 PDT, Brady Eidson
achristensen: review+
Brady Eidson
Comment 1 2015-09-14 22:29:54 PDT
Created attachment 261175 [details] Patch v1 For an EWS run - Not including ChangeLogs because I have other changes locally that would cause this to not apply on EWS. Definitely reviewable, though.
Brady Eidson
Comment 2 2015-09-15 08:53:38 PDT
Created attachment 261193 [details] Patch v2
Alex Christensen
Comment 3 2015-09-15 08:57:40 PDT
Comment on attachment 261193 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=261193&action=review r=me if ews passes > Source/WebKit2/Shared/WebCoreArgumentCoders.h:405 > template<> struct ArgumentCoder<WebCore::IDBGetResult> { IDBGetResult feels left out :(
Brady Eidson
Comment 4 2015-09-15 09:11:59 PDT
(In reply to comment #3) > Comment on attachment 261193 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261193&action=review > > r=me if ews passes > > > Source/WebKit2/Shared/WebCoreArgumentCoders.h:405 > > template<> struct ArgumentCoder<WebCore::IDBGetResult> { > > IDBGetResult feels left out :( It can't be moved right now because it uses DataReference which is WK2-only. But good news - While resolving https://bugs.webkit.org/show_bug.cgi?id=149117, IDBGetResult will be going away entirely. :)
Brady Eidson
Comment 5 2015-09-15 09:34:02 PDT
The EFL failure: ../../Source/WebCore/Modules/indexeddb/IDBKeyPath.h: In static member function 'static bool WebCore::IDBKeyPath::decode(Decoder&, WebCore::IDBKeyPath&) [with Decoder = IPC::ArgumentDecoder]': ../../Source/WebCore/Modules/indexeddb/IDBKeyPath.h:140:1: error: control reaches end of non-void function [-Werror=return-type] ...Even though all switch cases are accounted for. :( Stupid compiler. Will fix.
Brady Eidson
Comment 6 2015-09-15 09:36:47 PDT
Note You need to log in before you can comment on or make changes to this bug.