Bug 149150 - Web Inspector: Watch Expressions uncaught exceptions on page reload
Summary: Web Inspector: Watch Expressions uncaught exceptions on page reload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-14 21:01 PDT by Joseph Pecoraro
Modified: 2015-09-15 11:36 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (6.14 KB, patch)
2015-09-14 21:04 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-14 21:01:16 PDT
* SUMMARY
Watch Expressions uncaught exceptions on page reload.

* STEPS TO REPRODUCE
1. Add "document.activeElement" watch expression
2. Pause in some script
3. Reload
  => Error logged to console

* NOTES
- Because DebuggerManager.Resume does not trigger immediately, the activeCallFrame is invalid when re-evaluating the watch expressions.
  - We should immediately Resume when main frame changes instead of waiting for the 50ms delay (which already causes some problems)
Comment 1 Joseph Pecoraro 2015-09-14 21:04:05 PDT
Created attachment 261168 [details]
[PATCH] Proposed Fix
Comment 2 Radar WebKit Bug Importer 2015-09-14 21:05:02 PDT
<rdar://problem/22696954>
Comment 3 Radar WebKit Bug Importer 2015-09-14 21:05:20 PDT
<rdar://problem/22696963>
Comment 4 BJ Burg 2015-09-15 09:09:00 PDT
Comment on attachment 261168 [details]
[PATCH] Proposed Fix

r=me

Is this too flaky to test?
Comment 5 Joseph Pecoraro 2015-09-15 10:19:24 PDT
(In reply to comment #4)
> Comment on attachment 261168 [details]
> [PATCH] Proposed Fix
> 
> r=me
> 
> Is this too flaky to test?

Not flakey, just the Watch Expressions stuff is refreshed in view code.
Comment 6 WebKit Commit Bot 2015-09-15 11:36:18 PDT
Comment on attachment 261168 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 261168

Committed r189816: <http://trac.webkit.org/changeset/189816>
Comment 7 WebKit Commit Bot 2015-09-15 11:36:22 PDT
All reviewed patches have been landed.  Closing bug.