Bug 149149 – Make the enum IDBKey::Type into a utility enum class

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Make the enum IDBKey::Type into a utility enum class

It belongs in the IndexedDB.h utility header.

[Brady Eidson]

Created attachment 261167 [details]
Patch v1

[WebKit Commit Bot]

Attachment 261167 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBKey.h:146:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBKey.h:147:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBKey.h:148:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBKey.h:149:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 4 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 261167 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=261167&action=review

r=me

> Source/WebCore/Modules/indexeddb/IDBKey.h:37
> +using WebCore::IndexedDB::KeyType;

You shouldn't need this.  You have KeyType:: everywhere.

> Source/WebCore/Modules/indexeddb/IndexedDB.h:63
> +    Max = -1,

Why not put Max at the end?

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1922
>          // MaxType and MinType are only used for comparison to other keys.

change

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1958
>          // MaxType and MinType are only used for comparison to other keys.

Change comment, too

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 261167 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261167&action=review
> 
> r=me
> 
> > Source/WebCore/Modules/indexeddb/IDBKey.h:37
> > +using WebCore::IndexedDB::KeyType;
> 
> You shouldn't need this.  You have KeyType:: everywhere.

Except I don't have IndexedDB everywhere, and don't want to pull in the entire namespace.

> 
> > Source/WebCore/Modules/indexeddb/IndexedDB.h:63
> > +    Max = -1,
> 
> Why not put Max at the end?

There's actually a spec-defined comparison order for IDB keys, and for many reasons we put the enums in reverse order.

> > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1922
> >          // MaxType and MinType are only used for comparison to other keys.
> 
> change
> 
> > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1958
> >          // MaxType and MinType are only used for comparison to other keys.
> 
> Change comment, too

Oh thanks!

[Brady Eidson]

https://trac.webkit.org/changeset/189809