Bug 149147 - Add initial support for [Unforgeable] IDL extended attribute
Summary: Add initial support for [Unforgeable] IDL extended attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://heycam.github.io/webidl/#Unfo...
Keywords: WebExposed
: 124734 (view as bug list)
Depends on:
Blocks: 76121
  Show dependency treegraph
 
Reported: 2015-09-14 19:53 PDT by Chris Dumez
Modified: 2015-11-12 21:07 PST (History)
7 users (show)

See Also:


Attachments
Patch (20.40 KB, patch)
2015-09-15 13:37 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (604.34 KB, application/zip)
2015-09-15 14:16 PDT, Build Bot
no flags Details
Patch (22.41 KB, patch)
2015-09-15 14:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mavericks (733.72 KB, application/zip)
2015-09-15 15:18 PDT, Build Bot
no flags Details
Patch (22.32 KB, patch)
2015-09-15 19:20 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-14 19:53:27 PDT
Add support for [Unforgeable] IDL extended attribute:
https://heycam.github.io/webidl/#Unforgeable

In particular, when [Unforgeable] is present, the property should be non-configurable and will exist as an own property on the object itself rather than on its prototype.
Comment 1 Chris Dumez 2015-09-15 13:37:31 PDT
Created attachment 261226 [details]
Patch
Comment 2 Build Bot 2015-09-15 14:16:55 PDT
Comment on attachment 261226 [details]
Patch

Attachment 261226 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/174352

New failing tests:
http/tests/security/cross-frame-access-enumeration.html
Comment 3 Build Bot 2015-09-15 14:16:58 PDT
Created attachment 261235 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Chris Dumez 2015-09-15 14:21:32 PDT
Created attachment 261237 [details]
Patch
Comment 5 Build Bot 2015-09-15 15:18:04 PDT
Comment on attachment 261237 [details]
Patch

Attachment 261237 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/174475

New failing tests:
http/tests/security/cross-frame-access-enumeration.html
Comment 6 Build Bot 2015-09-15 15:18:08 PDT
Created attachment 261247 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 7 Chris Dumez 2015-09-15 19:20:32 PDT
Created attachment 261281 [details]
Patch
Comment 8 WebKit Commit Bot 2015-09-16 10:46:39 PDT
Comment on attachment 261281 [details]
Patch

Clearing flags on attachment: 261281

Committed r189873: <http://trac.webkit.org/changeset/189873>
Comment 9 WebKit Commit Bot 2015-09-16 10:46:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Joseph Pecoraro 2015-11-12 21:07:31 PST
*** Bug 124734 has been marked as a duplicate of this bug. ***