Bug 149141 - Add stub implementation of Presentation API
Summary: Add stub implementation of Presentation API
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-14 16:04 PDT by Jer Noble
Modified: 2019-05-09 08:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (72.13 KB, patch)
2015-09-15 10:46 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (72.13 KB, patch)
2015-09-15 10:53 PDT, Jer Noble 		beidson: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-09-14 16:04:30 PDT 
Add stub implementation of Presentation API
Comment 1 Jer Noble 2015-09-15 10:46:32 PDT 
Created attachment 261209 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-15 10:49:52 PDT 
Attachment 261209 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/presentation/PresentationRequest.cpp:40:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jer Noble 2015-09-15 10:53:34 PDT 
Created attachment 261214 [details]
Patch
Comment 4 Brady Eidson 2017-04-24 19:09:17 PDT 
Comment on attachment 261214 [details]
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.