Bug 149123 - Progress towards cmake on mac
Summary: Progress towards cmake on mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-14 11:33 PDT by Alex Christensen
Modified: 2015-09-14 14:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (59.23 KB, patch)
2015-09-14 11:46 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (58.97 KB, patch)
2015-09-14 12:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.13 KB, patch)
2015-09-14 12:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.47 KB, patch)
2015-09-14 12:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.71 KB, patch)
2015-09-14 13:23 PDT, Alex Christensen 		cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-09-14 11:33:03 PDT 
I made a lot of progress.
Comment 1 Alex Christensen 2015-09-14 11:46:43 PDT 
Created attachment 261118 [details]
Patch
Comment 2 Alex Christensen 2015-09-14 12:12:16 PDT 
Created attachment 261119 [details]
Patch
Comment 3 Alex Christensen 2015-09-14 12:25:49 PDT 
Created attachment 261120 [details]
Patch
Comment 4 Alex Christensen 2015-09-14 12:55:10 PDT 
Created attachment 261122 [details]
Patch
Comment 5 Alex Christensen 2015-09-14 13:23:29 PDT 
Created attachment 261126 [details]
Patch
Comment 6 Chris Dumez 2015-09-14 14:12:39 PDT 
Comment on attachment 261126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261126&action=review

rs=me with comments.

> Source/WebCore/CMakeLists.txt:267
> +    Modules/plugins/QuickTimePluginReplacement.idl

This should be Mac-specific.

> Source/WebCore/rendering/CounterNode.cpp:83
> +                    if (nextSibling)

Why this change?
Comment 7 Alex Christensen 2015-09-14 14:23:41 PDT 
(In reply to comment #6)
> Comment on attachment 261126 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261126&action=review
> 
> rs=me with comments.
> 
> > Source/WebCore/CMakeLists.txt:267
> > +    Modules/plugins/QuickTimePluginReplacement.idl
> 
> This should be Mac-specific.
Skipped for now.
> 
> > Source/WebCore/rendering/CounterNode.cpp:83
> > +                    if (nextSibling)
> 
> Why this change?
This is related to another patch.  I didn't commit it.

http://trac.webkit.org/changeset/189749