RESOLVED FIXED 149123
Progress towards cmake on mac 
https://bugs.webkit.org/show_bug.cgi?id=149123
Summary Progress towards cmake on mac
Alex Christensen
Reported 2015-09-14 11:33:03 PDT
I made a lot of progress.
Attachments
Patch (59.23 KB, patch)
2015-09-14 11:46 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (58.97 KB, patch)
2015-09-14 12:12 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (60.13 KB, patch)
2015-09-14 12:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (60.47 KB, patch)
2015-09-14 12:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (60.71 KB, patch)
2015-09-14 13:23 PDT, Alex Christensen 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-09-14 11:46:43 PDT
Created attachment 261118 [details] Patch
Alex Christensen
Comment 2 2015-09-14 12:12:16 PDT
Created attachment 261119 [details] Patch
Alex Christensen
Comment 3 2015-09-14 12:25:49 PDT
Created attachment 261120 [details] Patch
Alex Christensen
Comment 4 2015-09-14 12:55:10 PDT
Created attachment 261122 [details] Patch
Alex Christensen
Comment 5 2015-09-14 13:23:29 PDT
Created attachment 261126 [details] Patch
Chris Dumez
Comment 6 2015-09-14 14:12:39 PDT
Comment on attachment 261126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261126&action=review rs=me with comments. > Source/WebCore/CMakeLists.txt:267 > + Modules/plugins/QuickTimePluginReplacement.idl This should be Mac-specific. > Source/WebCore/rendering/CounterNode.cpp:83 > + if (nextSibling) Why this change?
Alex Christensen
Comment 7 2015-09-14 14:23:41 PDT
(In reply to comment #6) > Comment on attachment 261126 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261126&action=review > > rs=me with comments. > > > Source/WebCore/CMakeLists.txt:267 > > + Modules/plugins/QuickTimePluginReplacement.idl > > This should be Mac-specific. Skipped for now. > > > Source/WebCore/rendering/CounterNode.cpp:83 > > + if (nextSibling) > > Why this change? This is related to another patch. I didn't commit it. http://trac.webkit.org/changeset/189749
Note You need to log in before you can comment on or make changes to this bug.