Bug 149121 - Web Inspector: Turn off line wrapping in resource text editors
Summary: Web Inspector: Turn off line wrapping in resource text editors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-14 11:08 PDT by Joseph Pecoraro
Modified: 2015-09-16 10:38 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.52 KB, patch)
2015-09-14 11:09 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-14 11:08:39 PDT
* SUMMARY
Turn off line wrapping in resource text editors.

* NOTES
- Firefox and Chrome both do not have line wrapping in these cases.
- In pretty printing cases, it looks unusual to have a line wrapped even when pretty printed
Comment 1 Joseph Pecoraro 2015-09-14 11:08:53 PDT
<rdar://problem/22677239>
Comment 2 Joseph Pecoraro 2015-09-14 11:09:37 PDT
Created attachment 261115 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2015-09-15 09:26:38 PDT
Comment on attachment 261115 [details]
[PATCH] Proposed Fix

This seems kind of subjective. In many cases (HTML with huge inline styles) it's unusable without line wrapping. Should we defer until editor settings are added?
Comment 4 Joseph Pecoraro 2015-09-15 10:04:00 PDT
(In reply to comment #3)
> Comment on attachment 261115 [details]
> [PATCH] Proposed Fix
> 
> This seems kind of subjective. In many cases (HTML with huge inline styles)
> it's unusable without line wrapping. Should we defer until editor settings
> are added?

I'm fine with deferring / blocking on:
<https://webkit.org/b/149120> Web Inspector: Preferences for Text Editor behavior
Comment 5 WebKit Commit Bot 2015-09-16 10:38:45 PDT
Comment on attachment 261115 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 261115

Committed r189872: <http://trac.webkit.org/changeset/189872>
Comment 6 WebKit Commit Bot 2015-09-16 10:38:49 PDT
All reviewed patches have been landed.  Closing bug.