1. http://www.w3schools.com/html/html5_video.asp 2. Click a playbutton over keeping a cursor on the button. 3. Repeat clicking the button.
Created attachment 261630 [details] Patch
Created attachment 261631 [details] Patch
Comment on attachment 261631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261631&action=review > Source/WebCore/ChangeLog:13 > + does not define the -webkit-media-controls-play-button.paused. To fix this, > + the button needs to be updated forcedly when its style change happens by changing Wouldn't it be simpler to define that ...button.paused in our CSS and somehow make it void?
Comment on attachment 261631 [details] Patch Attachment 261631 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/192315 New failing tests: media/media-controls-play-button-updates.html
Created attachment 261636 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Do you have any idea for a candidate style to be added? =) The new style should not be duplicated. I tried it for a while, I could not find a proper style which should be new but not affect on the existing appearance of the button. :P
Comment on attachment 261631 [details] Patch Attachment 261631 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/192324 New failing tests: media/media-controls-play-button-updates.html
Created attachment 261637 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 261725 [details] Patch
Created attachment 261805 [details] Patch
Comment on attachment 261805 [details] Patch Clearing flags on attachment: 261805 Committed r190160: <http://trac.webkit.org/changeset/190160>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 149501
Created attachment 261860 [details] Patch
(In reply to comment #14) > Created attachment 261860 [details] > Patch Already got r+, and just TestExpectations are updated for mac yosemite and efl. I will land this again, if no objection. Thanks.
Have you investigated the failures?
(In reply to comment #16) > Have you investigated the failures? Yes, I do. The attached expected results are for gtk and mac-mavericks. Maybe mac-yosemite was not happy with the result for mavericks. And results for efl is missing since I have no efl build now.
Comment on attachment 261860 [details] Patch Clearing flags on attachment: 261860 Committed r190200: <http://trac.webkit.org/changeset/190200>
Who is going to unskip the test on OS X Yosemite and El Capitan? Or if it's not relevant on Mac, it should be marked WontFix on all OS X versions, making a special case for Mavericks makes no sense.
(In reply to comment #20) > Who is going to unskip the test on OS X Yosemite and El Capitan? > > Or if it's not relevant on Mac, it should be marked WontFix on all OS X > versions, making a special case for Mavericks makes no sense. I did not make a special case for Mavericks. That was an only result that I could get from ews for mac. Mac port guys can rebase it on yosemite. Or else just provide me expected.txt/png for yosemite, I can update it for you.
(In reply to comment #21) > (In reply to comment #20) > > Who is going to unskip the test on OS X Yosemite and El Capitan? > > > > Or if it's not relevant on Mac, it should be marked WontFix on all OS X > > versions, making a special case for Mavericks makes no sense. > > I did not make a special case for Mavericks. That was an only result that I > could get from ews for mac. Mac port guys can rebase it on yosemite. Or else > just provide me expected.txt/png for yosemite, I can update it for you. My understanding is that it is slightly more nuanced because the results are different on Debug and Release for Yosemite and El Capitan.
(In reply to comment #22) > (In reply to comment #21) > > (In reply to comment #20) > > > Who is going to unskip the test on OS X Yosemite and El Capitan? > > > > > > Or if it's not relevant on Mac, it should be marked WontFix on all OS X > > > versions, making a special case for Mavericks makes no sense. > > > > I did not make a special case for Mavericks. That was an only result that I > > could get from ews for mac. Mac port guys can rebase it on yosemite. Or else > > just provide me expected.txt/png for yosemite, I can update it for you. > > My understanding is that it is slightly more nuanced because the results are > different on Debug and Release for Yosemite and El Capitan. It is odd. Just adding expected results for the platforms should be enough. :/ How are they different? Both textdiff and image diff happen? Anyway.. My mac is not available. I can check it during next week.
What's the latest on this?
You missed to update some baselines after this changes. I have done that on http://trac.webkit.org/changeset/193853