Bug 149113 - [GTK] playbutton in media controls is not changed when it is clicked.
Summary: [GTK] playbutton in media controls is not changed when it is clicked.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords:
Depends on: 149501
Blocks: 149396
  Show dependency treegraph
 
Reported: 2015-09-13 22:24 PDT by ChangSeok Oh
Modified: 2015-12-09 12:13 PST (History)
11 users (show)

See Also:


Attachments
Patch (34.76 KB, patch)
2015-09-20 23:43 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff
Patch (34.76 KB, patch)
2015-09-20 23:50 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (643.70 KB, application/zip)
2015-09-21 00:23 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (693.77 KB, application/zip)
2015-09-21 00:28 PDT, Build Bot
no flags Details
Patch (79.66 KB, patch)
2015-09-21 22:37 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff
Patch (77.91 KB, patch)
2015-09-23 00:52 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff
Patch (79.60 KB, patch)
2015-09-23 21:59 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2015-09-13 22:24:24 PDT
1. http://www.w3schools.com/html/html5_video.asp
2. Click a playbutton over keeping a cursor on the button.
3. Repeat clicking the button.
Comment 1 ChangSeok Oh 2015-09-20 23:43:32 PDT
Created attachment 261630 [details]
Patch
Comment 2 ChangSeok Oh 2015-09-20 23:50:43 PDT
Created attachment 261631 [details]
Patch
Comment 3 Philippe Normand 2015-09-21 00:01:27 PDT
Comment on attachment 261631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261631&action=review

> Source/WebCore/ChangeLog:13
> +        does not define the -webkit-media-controls-play-button.paused. To fix this,
> +        the button needs to be updated forcedly when its style change happens by changing

Wouldn't it be simpler to define that ...button.paused in our CSS and somehow make it void?
Comment 4 Build Bot 2015-09-21 00:22:59 PDT
Comment on attachment 261631 [details]
Patch

Attachment 261631 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/192315

New failing tests:
media/media-controls-play-button-updates.html
Comment 5 Build Bot 2015-09-21 00:23:02 PDT
Created attachment 261636 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 ChangSeok Oh 2015-09-21 00:27:03 PDT
Do you have any idea for a candidate style to be added? =)
The new style should not be duplicated. I tried it for a while, I could not find a proper style which should be new but not affect on the existing appearance of the button. :P
Comment 7 Build Bot 2015-09-21 00:28:39 PDT
Comment on attachment 261631 [details]
Patch

Attachment 261631 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/192324

New failing tests:
media/media-controls-play-button-updates.html
Comment 8 Build Bot 2015-09-21 00:28:44 PDT
Created attachment 261637 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 9 ChangSeok Oh 2015-09-21 22:37:11 PDT
Created attachment 261725 [details]
Patch
Comment 10 ChangSeok Oh 2015-09-23 00:52:41 PDT
Created attachment 261805 [details]
Patch
Comment 11 WebKit Commit Bot 2015-09-23 04:07:36 PDT
Comment on attachment 261805 [details]
Patch

Clearing flags on attachment: 261805

Committed r190160: <http://trac.webkit.org/changeset/190160>
Comment 12 WebKit Commit Bot 2015-09-23 04:07:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 WebKit Commit Bot 2015-09-23 08:30:49 PDT
Re-opened since this is blocked by bug 149501
Comment 14 ChangSeok Oh 2015-09-23 21:59:15 PDT
Created attachment 261860 [details]
Patch
Comment 15 ChangSeok Oh 2015-09-23 22:02:19 PDT
(In reply to comment #14)
> Created attachment 261860 [details]
> Patch

Already got r+, and just TestExpectations are updated for mac yosemite and efl.
I will land this again, if no objection. Thanks.
Comment 16 Philippe Normand 2015-09-24 00:02:49 PDT
Have you investigated the failures?
Comment 17 ChangSeok Oh 2015-09-24 00:38:04 PDT
(In reply to comment #16)
> Have you investigated the failures?

Yes, I do. The attached expected results are for gtk and mac-mavericks.
Maybe mac-yosemite was not happy with the result for mavericks. And results for efl is missing since I have no efl build now.
Comment 18 WebKit Commit Bot 2015-09-24 02:41:27 PDT
Comment on attachment 261860 [details]
Patch

Clearing flags on attachment: 261860

Committed r190200: <http://trac.webkit.org/changeset/190200>
Comment 19 WebKit Commit Bot 2015-09-24 02:41:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 20 Alexey Proskuryakov 2015-09-24 18:11:41 PDT
Who is going to unskip the test on OS X Yosemite and El Capitan? 

Or if it's not relevant on Mac, it should be marked WontFix on all OS X versions, making a special case for Mavericks makes no sense.
Comment 21 ChangSeok Oh 2015-09-24 19:59:49 PDT
(In reply to comment #20)
> Who is going to unskip the test on OS X Yosemite and El Capitan? 
> 
> Or if it's not relevant on Mac, it should be marked WontFix on all OS X
> versions, making a special case for Mavericks makes no sense.

I did not make a special case for Mavericks. That was an only result that I could get from ews for mac. Mac port guys can rebase it on yosemite. Or else just provide me expected.txt/png for yosemite, I can update it for you.
Comment 22 Beth Dakin 2015-09-24 22:03:31 PDT
(In reply to comment #21)
> (In reply to comment #20)
> > Who is going to unskip the test on OS X Yosemite and El Capitan? 
> > 
> > Or if it's not relevant on Mac, it should be marked WontFix on all OS X
> > versions, making a special case for Mavericks makes no sense.
> 
> I did not make a special case for Mavericks. That was an only result that I
> could get from ews for mac. Mac port guys can rebase it on yosemite. Or else
> just provide me expected.txt/png for yosemite, I can update it for you.

My understanding is that it is slightly more nuanced because the results are different on Debug and Release for Yosemite and El Capitan.
Comment 23 ChangSeok Oh 2015-09-24 23:28:54 PDT
(In reply to comment #22)
> (In reply to comment #21)
> > (In reply to comment #20)
> > > Who is going to unskip the test on OS X Yosemite and El Capitan? 
> > > 
> > > Or if it's not relevant on Mac, it should be marked WontFix on all OS X
> > > versions, making a special case for Mavericks makes no sense.
> > 
> > I did not make a special case for Mavericks. That was an only result that I
> > could get from ews for mac. Mac port guys can rebase it on yosemite. Or else
> > just provide me expected.txt/png for yosemite, I can update it for you.
> 
> My understanding is that it is slightly more nuanced because the results are
> different on Debug and Release for Yosemite and El Capitan.

It is odd. Just adding expected results for the platforms should be enough. :/ How are they different? Both textdiff and image diff happen?
Anyway.. My mac is not available. I can check it during next week.
Comment 24 Jon Lee 2015-10-30 13:45:52 PDT
What's the latest on this?
Comment 25 Carlos Alberto Lopez Perez 2015-12-09 12:13:51 PST
You missed to update some baselines after this changes. I have done that on http://trac.webkit.org/changeset/193853