Bug 149110 - [EFL] Remove create() factory function in EvasGLContext and EvasGLSurface
Summary: [EFL] Remove create() factory function in EvasGLContext and EvasGLSurface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-13 22:00 PDT by Gyuyoung Kim
Modified: 2015-09-14 06:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.80 KB, patch)
2015-09-13 22:03 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2015-09-13 22:10 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (5.80 KB, patch)
2015-09-13 22:19 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-09-13 22:00:55 PDT 
It is not good implementation we support both create() factory function and public constructor. In EvasGLContext case, it has supported both. However create() factory is only used by EwkView. Thus remove the create() function, then EwkView creates EvasGLContext using std::make_unique<> directly.
Comment 1 Gyuyoung Kim 2015-09-13 22:03:18 PDT 
Created attachment 261100 [details]
Patch
Comment 2 Gyuyoung Kim 2015-09-13 22:10:22 PDT 
Created attachment 261101 [details]
Patch
Comment 3 WebKit Commit Bot 2015-09-13 22:13:08 PDT 
Attachment 261101 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gyuyoung Kim 2015-09-13 22:19:27 PDT 
Created attachment 261102 [details]
Patch
Comment 5 WebKit Commit Bot 2015-09-14 06:55:24 PDT 
Comment on attachment 261102 [details]
Patch

Clearing flags on attachment: 261102

Committed r189728: <http://trac.webkit.org/changeset/189728>
Comment 6 WebKit Commit Bot 2015-09-14 06:55:28 PDT 
All reviewed patches have been landed.  Closing bug.