Bug 149102 – Implement the arithmetic instructions for floats in WebAssembly

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Sukolsak Sakshuwong]

Implement the arithmetic instructions for floats (float32) in WebAssembly.

[Sukolsak Sakshuwong]

Created attachment 261106 [details]
Patch

[WebKit Commit Bot]

Attachment 261106 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:844:  JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 261106 [details]
Patch

These conversions are pretty expensive. Why not just do the math as float?

[Sukolsak Sakshuwong]

Thanks for the review.

(In reply to comment #3)
> Comment on attachment 261106 [details]
> Patch
> 
> These conversions are pretty expensive. Why not just do the math as float?

Our macro assembler currently doesn't have any float arithmetic instructions. I could add them for x86, x86-64, and ARM. But I am not sure how to add and test them on MIPS and SH4. Is it OK if I just add them for x86, x86-64, and ARM and do something like

#if CPU(X86) || CPU(X86_64)
    m_assembler.addsd_rr(...);
#elif CPU(ARM) || CPU(ARM64) 
    m_assembler....(...);
#else
    convertFloatToDouble(FPRInfo::fpRegT0, FPRInfo::fpRegT0);
    addDouble(FPRInfo::fpRegT1, FPRInfo::fpRegT0);
    convertDoubleToFloat(FPRInfo::fpRegT0, FPRInfo::fpRegT0);
#endif

?

[WebKit Commit Bot]

Comment on attachment 261106 [details]
Patch

Clearing flags on attachment: 261106

Committed r189744: <http://trac.webkit.org/changeset/189744>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.