WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149097
Document.adoptNode() should be able to explicitly adopt a DocumentType node
https://bugs.webkit.org/show_bug.cgi?id=149097
Summary
Document.adoptNode() should be able to explicitly adopt a DocumentType node
Chris Dumez
Reported
2015-09-12 15:05:34 PDT
Document.adoptNode() should be able to explicitly adopt a DocumentType node:
https://dom.spec.whatwg.org/#dom-document-adoptnode
WebKit currently throws a NotSupportedError. Chrome and Firefox match the spec amd adopt the DocumentType.
Attachments
Patch
(3.27 KB, patch)
2015-09-12 15:25 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2
(668.17 KB, application/zip)
2015-09-12 16:04 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews101 for mac-mavericks
(619.79 KB, application/zip)
2015-09-12 16:15 PDT
,
Build Bot
no flags
Details
Patch
(5.82 KB, patch)
2015-09-12 18:43 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2015-09-12 15:06:03 PDT
rdar://problem/22549345
Chris Dumez
Comment 2
2015-09-12 15:25:03 PDT
Created
attachment 261065
[details]
Patch
Build Bot
Comment 3
2015-09-12 16:04:02 PDT
Comment on
attachment 261065
[details]
Patch
Attachment 261065
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/165752
New failing tests: dom/xhtml/level3/core/documentadoptnode12.xhtml dom/xhtml/level3/core/documentadoptnode11.xhtml dom/xhtml/level3/core/documentadoptnode10.xhtml
Build Bot
Comment 4
2015-09-12 16:04:06 PDT
Created
attachment 261066
[details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 5
2015-09-12 16:15:10 PDT
Comment on
attachment 261065
[details]
Patch
Attachment 261065
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/165776
New failing tests: dom/xhtml/level3/core/documentadoptnode12.xhtml dom/xhtml/level3/core/documentadoptnode11.xhtml dom/xhtml/level3/core/documentadoptnode10.xhtml
Build Bot
Comment 6
2015-09-12 16:15:15 PDT
Created
attachment 261067
[details]
Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Chris Dumez
Comment 7
2015-09-12 18:43:01 PDT
Created
attachment 261071
[details]
Patch
Ryosuke Niwa
Comment 8
2015-09-13 21:19:52 PDT
Comment on
attachment 261071
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=261071&action=review
> LayoutTests/dom/xhtml/level3/core/documentadoptnode10-expected.txt:2 > -Status Success > +Status failure
I wonder if we should just remove these dom3 tests... They seem to be completely obsolete by now.
Chris Dumez
Comment 9
2015-09-13 22:06:51 PDT
Comment on
attachment 261071
[details]
Patch Clearing flags on attachment: 261071 Committed
r189681
: <
http://trac.webkit.org/changeset/189681
>
Chris Dumez
Comment 10
2015-09-13 22:06:57 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug