Bug 149080 - Implement the relational instructions for floats in WebAssembly
Summary: Implement the relational instructions for floats in WebAssembly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 146064
  Show dependency tree / graph
 
Reported: 2015-09-11 16:45 PDT by Sukolsak Sakshuwong
Modified: 2015-09-11 17:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.14 KB, patch)
2015-09-11 16:59 PDT, Sukolsak Sakshuwong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-11 16:45:44 PDT 
Implement the relational instructions for floats in WebAssembly
Comment 1 Sukolsak Sakshuwong 2015-09-11 16:59:19 PDT 
Created attachment 261032 [details]
Patch
Comment 2 Geoffrey Garen 2015-09-11 17:11:05 PDT 
Comment on attachment 261032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261032&action=review

r=me

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:546
> +        Jump trueCase = branchDouble(condition, FPRInfo::fpRegT0, FPRInfo::fpRegT1);

It would be nice to use a simple compare rather than a compare-and-branch. But it looks like our assembler doesn't currently support that :(.
Comment 3 WebKit Commit Bot 2015-09-11 17:57:55 PDT 
Comment on attachment 261032 [details]
Patch

Clearing flags on attachment: 261032

Committed r189645: <http://trac.webkit.org/changeset/189645>
Comment 4 WebKit Commit Bot 2015-09-11 17:57:59 PDT 
All reviewed patches have been landed.  Closing bug.