WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149080
Implement the relational instructions for floats in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149080
Summary
Implement the relational instructions for floats in WebAssembly
Sukolsak Sakshuwong
Reported
2015-09-11 16:45:44 PDT
Implement the relational instructions for floats in WebAssembly
Attachments
Patch
(11.14 KB, patch)
2015-09-11 16:59 PDT
,
Sukolsak Sakshuwong
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1
2015-09-11 16:59:19 PDT
Created
attachment 261032
[details]
Patch
Geoffrey Garen
Comment 2
2015-09-11 17:11:05 PDT
Comment on
attachment 261032
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=261032&action=review
r=me
> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:546 > + Jump trueCase = branchDouble(condition, FPRInfo::fpRegT0, FPRInfo::fpRegT1);
It would be nice to use a simple compare rather than a compare-and-branch. But it looks like our assembler doesn't currently support that :(.
WebKit Commit Bot
Comment 3
2015-09-11 17:57:55 PDT
Comment on
attachment 261032
[details]
Patch Clearing flags on attachment: 261032 Committed
r189645
: <
http://trac.webkit.org/changeset/189645
>
WebKit Commit Bot
Comment 4
2015-09-11 17:57:59 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug