Bug 149077 - Still need view snapshotting code for non-IOSurface for the sim
Summary: Still need view snapshotting code for non-IOSurface for the sim
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-11 15:26 PDT by Beth Dakin
Modified: 2015-09-11 16:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.04 KB, patch)
2015-09-11 15:27 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-09-11 15:26:05 PDT 
l need view snapshotting code for non-IOSurface for the sim
Comment 1 Beth Dakin 2015-09-11 15:27:08 PDT 
Created attachment 261021 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-11 15:27:57 PDT 
Attachment 261021 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:150:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-09-11 15:30:15 PDT 
Comment on attachment 261021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261021&action=review

> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:570
> +#if USE(IOSURFACE)

No need. This is always true on Mac.

> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:819
> +#if USE(IOSURFACE)

No need. This is always true on Mac.
Comment 4 Beth Dakin 2015-09-11 15:33:44 PDT 
Thanks! http://trac.webkit.org/changeset/189635
Comment 5 Beth Dakin 2015-09-11 16:06:32 PDT 
Build fix: http://trac.webkit.org/changeset/189637