Bug 149046 - WebInspectorUI should have a WebPage reference
Summary: WebInspectorUI should have a WebPage reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-09-10 15:01 PDT by Joseph Pecoraro
Modified: 2015-09-10 18:42 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.50 KB, patch)
2015-09-10 15:02 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-10 15:01:39 PDT 
* SUMMARY
WebInspectorUI should have a WebPage reference.

No need for a pointer, the WebPage's lifetime surrounds this object's lifetime.

I did not do the same to WebKit::WebInspector, because that is an API::Object and someone could extend the lifetime (although I don't think we would handle that case properly if it did happen.
Comment 1 Joseph Pecoraro 2015-09-10 15:02:21 PDT 
Created attachment 260959 [details]
[PATCH] Proposed Fix
Comment 2 Geoffrey Garen 2015-09-10 17:55:17 PDT 
Comment on attachment 260959 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2015-09-10 18:42:20 PDT 
Comment on attachment 260959 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260959

Committed r189601: <http://trac.webkit.org/changeset/189601>
Comment 4 WebKit Commit Bot 2015-09-10 18:42:24 PDT 
All reviewed patches have been landed.  Closing bug.