RESOLVED FIXED 149046
WebInspectorUI should have a WebPage reference 
https://bugs.webkit.org/show_bug.cgi?id=149046
Summary WebInspectorUI should have a WebPage reference
Joseph Pecoraro
Reported 2015-09-10 15:01:39 PDT
* SUMMARY WebInspectorUI should have a WebPage reference. No need for a pointer, the WebPage's lifetime surrounds this object's lifetime. I did not do the same to WebKit::WebInspector, because that is an API::Object and someone could extend the lifetime (although I don't think we would handle that case properly if it did happen.
Attachments
[PATCH] Proposed Fix (5.50 KB, patch)
2015-09-10 15:02 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-09-10 15:02:21 PDT
Created attachment 260959 [details] [PATCH] Proposed Fix
Geoffrey Garen
Comment 2 2015-09-10 17:55:17 PDT
Comment on attachment 260959 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 3 2015-09-10 18:42:20 PDT
Comment on attachment 260959 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260959 Committed r189601: <http://trac.webkit.org/changeset/189601>
WebKit Commit Bot
Comment 4 2015-09-10 18:42:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.