Convert arguments to WebAssembly functions to the declared types
Created attachment 260915 [details] Patch
Comment on attachment 260915 [details] Patch r=me Can we avoid these conversions if we know that we have a WASM caller? Why is the test case skipped?
Comment on attachment 260915 [details] Patch Clearing flags on attachment: 260915 Committed r189582: <http://trac.webkit.org/changeset/189582>
All reviewed patches have been landed. Closing bug.
Thanks for the review! (In reply to comment #2) > Comment on attachment 260915 [details] > Patch > > r=me > > Can we avoid these conversions if we know that we have a WASM caller? Yes, that's one of the optimizations I plan to do. Maybe exported WASM functions should have two entry points? > Why is the test case skipped? Because WebAssembly is not enabled by default, so loadWebAssembly() is not defined by default. I will create a patch that removes the "@skip" and uses "if (loadWebAssembly !== undefined) { ... }"
> > Can we avoid these conversions if we know that we have a WASM caller? > > Yes, that's one of the optimizations I plan to do. Maybe exported WASM > functions should have two entry points? Yes -- I think we should either use two entry points or require non-WASM functions calling WASM functions to call through a thunk. > > Why is the test case skipped? > > Because WebAssembly is not enabled by default, so loadWebAssembly() is not > defined by default. I will create a patch that removes the "@skip" and uses > "if (loadWebAssembly !== undefined) { ... }" Sounds good. It seems like we have enough WASM functionality that we might want to enable WASM in trunk for testing -- even though we should leave the API for running WASM out of WebKit and Safari by default.