WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149028
ModuleProgramExecutable should provide CodeBlock to ScriptExecutable::forEachCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=149028
Summary
ModuleProgramExecutable should provide CodeBlock to ScriptExecutable::forEach...
Yusuke Suzuki
Reported
2015-09-09 19:06:47 PDT
ModuleProgramExecutable should provide CodeBlock to ScriptExecutable::forEachCodeBlock
Attachments
Patch
(2.22 KB, patch)
2015-09-09 19:07 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2015-09-09 19:07:42 PDT
Created
attachment 260903
[details]
Patch
Yusuke Suzuki
Comment 2
2015-09-09 19:11:01 PDT
I searched with FunctionExecutableType and ensured that ModuleProgramExecutableType is handled in the other place.
Yusuke Suzuki
Comment 3
2015-09-09 21:18:28 PDT
Comment on
attachment 260903
[details]
Patch I'll merge this to
https://bugs.webkit.org/show_bug.cgi?id=149027
Yusuke Suzuki
Comment 4
2015-09-09 21:18:50 PDT
*** This bug has been marked as a duplicate of
bug 149027
***
Yusuke Suzuki
Comment 5
2015-09-09 21:34:17 PDT
This is also difficult to reproduce this crash stably, so in the meantime, we
Yusuke Suzuki
Comment 6
2015-09-09 21:41:59 PDT
I attempted to merge this and
https://bugs.webkit.org/show_bug.cgi?id=149027
with GC related tests, but they are difficult to reproduce with the tests. So in the meantime, separate these patches.
Yusuke Suzuki
Comment 7
2015-09-09 21:43:23 PDT
These faults are figured out during the ES6 Module WebCore integration.
Michael Saboff
Comment 8
2015-09-10 06:09:22 PDT
Comment on
attachment 260903
[details]
Patch r=me
Yusuke Suzuki
Comment 9
2015-09-10 09:25:10 PDT
Comment on
attachment 260903
[details]
Patch Thank you!
WebKit Commit Bot
Comment 10
2015-09-10 10:11:45 PDT
Comment on
attachment 260903
[details]
Patch Clearing flags on attachment: 260903 Committed
r189571
: <
http://trac.webkit.org/changeset/189571
>
WebKit Commit Bot
Comment 11
2015-09-10 10:11:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug