Bug 148998 – Implement internal calls in WebAssembly

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Sukolsak Sakshuwong]

Implement internal calls to functions that return a 32-bit integer in WebAssembly

[Sukolsak Sakshuwong]

Created attachment 260849 [details]
Patch

[Geoffrey Garen]

Comment on attachment 260849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:685
> +    Vector<CallCompilationInfo> m_callCompilationInfo;

You need to do something to GC this correctly. See our other handling of CallLinkInfo.

[Filip Pizlo]

Comment on attachment 260849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review

>> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:685
>> +    Vector<CallCompilationInfo> m_callCompilationInfo;
> 
> You need to do something to GC this correctly. See our other handling of CallLinkInfo.

I think he's doing it right already.  The CallLinkInfos get added to a CodeBlock.  The CodeBlock then knows what to do.

[Geoffrey Garen]

Comment on attachment 260849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:642
> +        CallLinkInfo* info = m_codeBlock->addCallLinkInfo();

I see. Is good.

[Filip Pizlo]

Comment on attachment 260849 [details]
Patch

LGTM.

[WebKit Commit Bot]

Comment on attachment 260849 [details]
Patch

Clearing flags on attachment: 260849

Committed r189563: <http://trac.webkit.org/changeset/189563>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Geoffrey Garen]

Comment on attachment 260849 [details]
Patch

r=me