Bug 148998 - Implement internal calls in WebAssembly
Summary: Implement internal calls in WebAssembly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 146064
  Show dependency tree / graph
 
Reported: 2015-09-09 01:38 PDT by Sukolsak Sakshuwong
Modified: 2015-09-10 12:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.61 KB, patch)
2015-09-09 01:45 PDT, Sukolsak Sakshuwong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-09 01:38:47 PDT 
Implement internal calls to functions that return a 32-bit integer in WebAssembly
Comment 1 Sukolsak Sakshuwong 2015-09-09 01:45:53 PDT 
Created attachment 260849 [details]
Patch
Comment 2 Geoffrey Garen 2015-09-09 14:43:06 PDT 
Comment on attachment 260849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:685
> +    Vector<CallCompilationInfo> m_callCompilationInfo;

You need to do something to GC this correctly. See our other handling of CallLinkInfo.
Comment 3 Filip Pizlo 2015-09-09 16:29:16 PDT 
Comment on attachment 260849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review

>> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:685
>> +    Vector<CallCompilationInfo> m_callCompilationInfo;
> 
> You need to do something to GC this correctly. See our other handling of CallLinkInfo.

I think he's doing it right already.  The CallLinkInfos get added to a CodeBlock.  The CodeBlock then knows what to do.
Comment 4 Geoffrey Garen 2015-09-09 17:05:12 PDT 
Comment on attachment 260849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:642
> +        CallLinkInfo* info = m_codeBlock->addCallLinkInfo();

I see. Is good.
Comment 5 Filip Pizlo 2015-09-09 17:53:39 PDT 
Comment on attachment 260849 [details]
Patch

LGTM.
Comment 6 WebKit Commit Bot 2015-09-09 18:43:30 PDT 
Comment on attachment 260849 [details]
Patch

Clearing flags on attachment: 260849

Committed r189563: <http://trac.webkit.org/changeset/189563>
Comment 7 WebKit Commit Bot 2015-09-09 18:43:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Geoffrey Garen 2015-09-10 12:14:59 PDT 
Comment on attachment 260849 [details]
Patch

r=me