Bug 148995 - sendProcessWillSuspendImminently uses a wrong message flag
Summary: sendProcessWillSuspendImminently uses a wrong message flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-08 23:10 PDT by Alexey Proskuryakov
Modified: 2015-09-10 13:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2015-09-10 12:32 PDT, Daniel Bates
ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-09-08 23:10:37 PDT
WebProcessProxy::sendProcessWillSuspendImminently (and its NetworkProcess counterpart) passes IPC::InterruptWaitingIfSyncMessageArrives to sendSync, but this value can only be used with waitForMessage.

Not sure if this is a real bug - this flag gets interpreted as IPC::InformPlatformProcessWillSuspend, which may or may not be what we are after here.

This code was added in http://trac.webkit.org/r184105
Comment 1 Daniel Bates 2015-09-10 12:32:22 PDT
Created attachment 260940 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-09-10 12:51:34 PDT
Comment on attachment 260940 [details]
Patch

Looks good, however please make the same fix in NetworkProcessProxy.
Comment 3 Daniel Bates 2015-09-10 13:13:09 PDT
(In reply to comment #2)
> Comment on attachment 260940 [details]
> Patch
> 
> Looks good, however please make the same fix in NetworkProcessProxy.

Will fix before landing.
Comment 4 Daniel Bates 2015-09-10 13:14:05 PDT
Committed r189587: <http://trac.webkit.org/changeset/189587>