Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError: https://dom.spec.whatwg.org/#node (parameters are not nullable)
rdar://problem/22560883
rdar://problem/22559225
Created attachment 260811 [details] WIP Patch
Attachment 260811 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Element.cpp:324: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 117 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 260814 [details] Patch
Created attachment 260818 [details] Patch
Comment on attachment 260818 [details] Patch Attachment 260818 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/152475 New failing tests: js/dom/dot-node-base-exception.html
Created attachment 260822 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 260818 [details] Patch Attachment 260818 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/152514 New failing tests: js/dom/dot-node-base-exception.html fast/events/remove-target-with-shadow-in-drag.html
Created attachment 260824 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 260840 [details] Patch
Created attachment 260843 [details] Patch
Created attachment 260858 [details] Patch
Created attachment 260859 [details] Patch
Created attachment 260862 [details] Patch
Created attachment 260908 [details] Patch
Comment on attachment 260908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260908&action=review > Source/WebCore/editing/AppendNodeCommand.cpp:38 > -AppendNodeCommand::AppendNodeCommand(PassRefPtr<ContainerNode> parent, PassRefPtr<Node> node, EditAction editingAction) > +AppendNodeCommand::AppendNodeCommand(PassRefPtr<ContainerNode> parent, Node& node, EditAction editingAction) I think this should be Ref<Node>. > Source/WebCore/editing/AppendNodeCommand.h:35 > + static Ref<AppendNodeCommand> create(PassRefPtr<ContainerNode> parent, Node& node, EditAction editingAction) Ditto. > Source/WebCore/editing/AppendNodeCommand.h:41 > - AppendNodeCommand(PassRefPtr<ContainerNode> parent, PassRefPtr<Node>, EditAction); > + AppendNodeCommand(PassRefPtr<ContainerNode> parent, Node&, EditAction); Ditto. > Source/WebCore/editing/RemoveNodeCommand.cpp:37 > +RemoveNodeCommand::RemoveNodeCommand(Node& node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable) Ditto. > Source/WebCore/editing/RemoveNodeCommand.h:35 > - static Ref<RemoveNodeCommand> create(PassRefPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable) > + static Ref<RemoveNodeCommand> create(Node& node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable) Ditto. > Source/WebCore/editing/RemoveNodeCommand.h:41 > - explicit RemoveNodeCommand(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable); > + RemoveNodeCommand(Node&, ShouldAssumeContentIsAlwaysEditable); Ditto. > Source/WebCore/html/track/VTTRegion.h:92 > - PassRefPtr<HTMLDivElement> getDisplayTree(); > + HTMLDivElement& getDisplayTree(); We should use Ref<HTMLDivElement> instead.
Created attachment 260930 [details] Patch
Created attachment 260931 [details] Patch
Comment on attachment 260931 [details] Patch Clearing flags on attachment: 260931 Committed r189576: <http://trac.webkit.org/changeset/189576>
All reviewed patches have been landed. Closing bug.