Bug 148959 - document.importNode(node, deep): deep's default value should be false
Summary: document.importNode(node, deep): deep's default value should be false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#dom-docu...
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2015-09-08 09:07 PDT by Chris Dumez
Modified: 2015-09-08 12:39 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.10 KB, patch)
2015-09-08 09:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-08 09:07:58 PDT 
document.importNode(node, deep): deep's default value should be false:
https://dom.spec.whatwg.org/#interface-document
https://dom.spec.whatwg.org/#dom-document-importnode

Firefox and Chrome follow the specification. However, WebKit uses "true" for deep's default value.

Note that WebKit use to have "false" as default value but this was changed in Bug 71190 because the DOM spec said to use "false" at the time :(
Comment 1 Chris Dumez 2015-09-08 09:08:48 PDT 
rdar://problem/22558915
Comment 2 Chris Dumez 2015-09-08 09:51:37 PDT 
Created attachment 260765 [details]
Patch
Comment 3 WebKit Commit Bot 2015-09-08 12:39:50 PDT 
Comment on attachment 260765 [details]
Patch

Clearing flags on attachment: 260765

Committed r189502: <http://trac.webkit.org/changeset/189502>
Comment 4 WebKit Commit Bot 2015-09-08 12:39:54 PDT 
All reviewed patches have been landed.  Closing bug.