Bug 148955 - [JSC] Weak should only accept cell pointees.
Summary: [JSC] Weak should only accept cell pointees.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 149456
Blocks:
  Show dependency treegraph
 
Reported: 2015-09-08 08:10 PDT by Andreas Kling
Modified: 2015-09-22 05:17 PDT (History)
1 user (show)

See Also:


Attachments
Patch (96.95 KB, patch)
2015-09-08 08:20 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-09-08 08:10:17 PDT
JSC::WeakImpl already asserts that the weak pointee is a non-null JSCell*. We should enforce this at compile time with narrower types.
Comment 1 Andreas Kling 2015-09-08 08:20:51 PDT
Created attachment 260760 [details]
Patch
Comment 2 Geoffrey Garen 2015-09-10 17:52:10 PDT
Comment on attachment 260760 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-09-11 02:16:49 PDT
Comment on attachment 260760 [details]
Patch

Clearing flags on attachment: 260760

Committed r189616: <http://trac.webkit.org/changeset/189616>
Comment 4 WebKit Commit Bot 2015-09-11 02:16:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2015-09-22 05:17:14 PDT
Re-opened since this is blocked by bug 149456