Bug 148904 - Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
Summary: Add a test ensuring that scrolling in the middle of a page can't start a swip...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-05 15:14 PDT by Tim Horton
Modified: 2015-09-17 12:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.70 KB, patch)
2015-09-05 15:15 PDT, Tim Horton
mmaxfield: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-09-05 15:14:43 PDT
Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
Comment 1 Tim Horton 2015-09-05 15:15:20 PDT
Created attachment 260702 [details]
Patch
Comment 2 Tim Horton 2015-09-05 15:15:54 PDT
Myles, you might want to have a peek at the WKTR bit.
Comment 3 Myles C. Maxfield 2015-09-08 11:23:35 PDT
Comment on attachment 260702 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260702&action=review

> Tools/WebKitTestRunner/TestController.cpp:821
> +    return false;

Perhaps this should cause a parse error

> LayoutTests/swipe/main-frame-pinning-requirement.html:2
> +<!-- This test has to use threaded scrolling because we don't

I generally like to put this explanatory text in the markup itself so if you just load up the test you know what's going on.

> LayoutTests/swipe/main-frame-pinning-requirement.html:15
> +    eventSender.mouseMoveTo(100, 100);

Don't you have to skip this on iOS?

> LayoutTests/swipe/main-frame-pinning-requirement.html:66
> +    shouldBe(false, eventQueue.hasPendingEvents(), "Event queue should be empty. Both scroll events should be required to start the swipe because of the swipe-start hysteresis.");

Why don't these log when they pass?

Also isn't there a shouldBeFalse()?
Comment 4 Tim Horton 2015-09-17 12:22:35 PDT
http://trac.webkit.org/changeset/189922