Bug 148900 - Fix JSDollarVMPrototype after r189160
Summary: Fix JSDollarVMPrototype after r189160
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-05 10:04 PDT by Mark Lam
Modified: 2015-09-06 14:02 PDT (History)
5 users (show)

See Also:

Attachments
the fix. (1.64 KB, patch)
2015-09-05 10:08 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-09-05 10:04:24 PDT 
JSDollarVMPrototype needs to be updated to match http://trac.webkit.org/changeset/189160 i.e. remove the JSC::Function bit in its property attributes.
Comment 1 Mark Lam 2015-09-05 10:08:44 PDT 
Created attachment 260691 [details]
the fix.
Comment 2 Michael Saboff 2015-09-05 22:44:19 PDT 
Comment on attachment 260691 [details]
the fix.

r=me.
Comment 3 WebKit Commit Bot 2015-09-05 23:30:52 PDT 
Comment on attachment 260691 [details]
the fix.

Clearing flags on attachment: 260691

Committed r189443: <http://trac.webkit.org/changeset/189443>
Comment 4 WebKit Commit Bot 2015-09-05 23:30:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2015-09-06 13:41:33 PDT 
Why no regression test?
Comment 6 Mark Lam 2015-09-06 14:02:26 PDT 
(In reply to comment #5)
> Why no regression test?

http://trac.webkit.org/changeset/189160 makes it such that this is simply the new way (not using the JSC::Function attribute) of calling putDirectNativeFunction().  r189160 changed every other place that uses putDirectNativeFunction() but missed this one case.  I'm just following up on the missed case.  The original patch did not think that this change warranted a regression test, and I applied the same standard for this patch.