RESOLVED FIXED 148899
webkit-patch: Passing --no-review should submit patch to EWS by default
https://bugs.webkit.org/show_bug.cgi?id=148899
Summary webkit-patch: Passing --no-review should submit patch to EWS by default
Blaze Burg
Reported 2015-09-05 09:39:10 PDT
If you are a Good Person and use EWS to avoid build breaks, it's really tedious to set r? on a patch that's already reviewed then get a bunch of bug mail for no reason. It's also tedious to click "Submit For EWS" on every patch. There should just be an option, like $ webkit-patch upload --request-ews --no-review Which will click that button for us.
Attachments
Patch and unit tests (17.93 KB, patch)
2017-08-10 21:18 PDT, Daniel Bates
no flags
Patch and unit tests (18.18 KB, patch)
2017-08-14 10:00 PDT, Daniel Bates
ddkilzer: review+
Daniel Bates
Comment 1 2017-08-10 20:59:49 PDT
An alternative approach proposed in bug #54735 is to introduce a new "try" command "that basically [would] just be upload with --no-review and a pre-set title." I am leaning towards implementing this as proposed in this bug (comment #0) - as an optional flag - because then it could be supported by all of the applicable webkit-patch commands that post a patch: upload, post, and post-commits. The proposal in comment #0 suggests that the flag, --request-ews, just does one thing: submit the patch to EWS. Alternatively we could have the flag, maybe called --try, do more than one things, say do not mark the patch for review and submit the patch to EWS. Or even, upload the patch with a hardcoded name "For EWS Bots" (suggested by Eric Seidel in bug #54735, comment 1), do not mark the patch for review, and submit the patch to EWS. Thoughts?
Daniel Bates
Comment 2 2017-08-10 21:18:53 PDT
Created attachment 317914 [details] Patch and unit tests Here is a patch that adds a --submit-to-ews flag to commands upload, post, and post-commits. Its usage matches the proposal in comment #0: "webkit-patch upload --no-review --submit-to-ews ...". That is, it must be used in conjunction with --no-review to be effective. I also added a new command, submit-to-ews, that can take one or more attachment ids and submit them to EWS. This command can be used to submit an existing --no-review patch to EWS.
Darin Adler
Comment 3 2017-08-14 09:12:24 PDT
Looks good. I would use this. I wish "--submit-to-ews" was something shorter. Also annoying since I will always have to do both "--no-review" and "--submit-to-ews". Maybe submitting to EWS should be the default even when you say "--no-review" and there should be an option "--no-ews".
Daniel Bates
Comment 4 2017-08-14 10:00:45 PDT
Created attachment 318045 [details] Patch and unit tests
Daniel Bates
Comment 5 2017-08-14 10:01:45 PDT
(In reply to Darin Adler from comment #3) > Maybe submitting to EWS should be the default even when you say "--no-review" and there should be an option "--no-ews". I updated the patch to take this approach.
David Kilzer (:ddkilzer)
Comment 6 2017-08-14 10:26:20 PDT
Comment on attachment 318045 [details] Patch and unit tests r=me
Daniel Bates
Comment 7 2017-08-14 14:08:56 PDT
Actually, I am not going to land the dedicated submit-to-ews command part of the patch. I am not going to include this command because I do not see much value to adding it at least not in its current form that requires specifying attachment id(s), which can only be discovered by visiting the bug. If a person visits the bug then it is straightforward to click the Submit for EWS on the attachments they want to submit. We can always add such a submit-to-ews command in a follow up if more realistic use cases materialize.
Daniel Bates
Comment 8 2017-08-14 14:14:19 PDT
Radar WebKit Bug Importer
Comment 9 2017-08-14 14:15:36 PDT
Note You need to log in before you can comment on or make changes to this bug.