WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
148875
Web Inspector: Improve prepare-ChangeLog for multiple cases
https://bugs.webkit.org/show_bug.cgi?id=148875
Summary
Web Inspector: Improve prepare-ChangeLog for multiple cases
Joseph Pecoraro
Reported
2015-09-04 19:52:10 PDT
* SUMMARY Improve prepare-ChangeLog for multiple cases 1. InjectedScriptSource.js always produces nothing - this was because the entire file is inside of parenthesis (...) as part of an anonymous function expression (function(){ ... }) 2. Sometimes files start out good but then have produce very weird output later on. - this was because handing of "get" and "set" was too generic and detected map.get(...) as a function 3. Don't detect methods in Object Literals - this was for simplicity, we should do this but probably only at the global scope
Attachments
[PATCH] Proposed Fix
(9.78 KB, patch)
2015-09-04 19:55 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-09-04 19:52:24 PDT
<
rdar://problem/22590259
>
Joseph Pecoraro
Comment 2
2015-09-04 19:55:07 PDT
Created
attachment 260667
[details]
[PATCH] Proposed Fix
WebKit Commit Bot
Comment 3
2015-09-05 10:33:27 PDT
Comment on
attachment 260667
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 260667 Committed
r189435
: <
http://trac.webkit.org/changeset/189435
>
WebKit Commit Bot
Comment 4
2015-09-05 10:33:30 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug