Bug 148875 - Web Inspector: Improve prepare-ChangeLog for multiple cases
Summary: Web Inspector: Improve prepare-ChangeLog for multiple cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-04 19:52 PDT by Joseph Pecoraro
Modified: 2015-09-05 10:33 PDT (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (9.78 KB, patch)
2015-09-04 19:55 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-04 19:52:10 PDT 
* SUMMARY
Improve prepare-ChangeLog for multiple cases

1. InjectedScriptSource.js always produces nothing
  - this was because the entire file is inside of parenthesis (...) as part of an anonymous function expression (function(){ ... })

2. Sometimes files start out good but then have produce very weird output later on.
  - this was because handing of "get" and "set" was too generic and detected map.get(...) as a function

3. Don't detect methods in Object Literals
  - this was for simplicity, we should do this but probably only at the global scope
Comment 1 Radar WebKit Bug Importer 2015-09-04 19:52:24 PDT 
<rdar://problem/22590259>
Comment 2 Joseph Pecoraro 2015-09-04 19:55:07 PDT 
Created attachment 260667 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-09-05 10:33:27 PDT 
Comment on attachment 260667 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260667

Committed r189435: <http://trac.webkit.org/changeset/189435>
Comment 4 WebKit Commit Bot 2015-09-05 10:33:30 PDT 
All reviewed patches have been landed.  Closing bug.