Bug 148857 – bgsound should use HTMLUnknownElement interface

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

See https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis

"The blink, bgsound, isindex, multicol, nextid, rb, and spacer elements must use the HTMLUnknownElement interface."

This bug was found by the newly added:
LayoutTests/http/tests/w3c/html/semantics/interfaces.html

[Ryosuke Niwa]

<rdar://problem/22589036>

[Chris Dumez]

Firefox:
bgsound -> HTMLUnknownElement
rb -> HTMLElement

Chrome:
bgsound -> HTMLUnknownElement
rb -> HTMLUnknownElement

Safari:
bgsound -> HTMLElement
rb -> HTMLElement

Spec:
bgsound -> HTMLUnknownElement
rb -> HTMLUnknownElement

[Chris Dumez]

Created attachment 263635 [details]
Patch

[Build Bot]

Comment on attachment 263635 [details]
Patch

Attachment 263635 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/313660

New failing tests:
fast/css/bidi-override-in-anonymous-block.html
html5lib/generated/run-tests25-write.html
html5lib/generated/run-ruby-write.html
html5lib/generated/run-tests19-write.html
html5lib/generated/run-ruby-data.html
html5lib/generated/run-tests25-data.html
html5lib/generated/run-tests19-data.html

[Build Bot]

Created attachment 263638 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263635 [details]
Patch

Attachment 263635 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/313656

New failing tests:
fast/css/bidi-override-in-anonymous-block.html
html5lib/generated/run-tests25-write.html
html5lib/generated/run-ruby-write.html
html5lib/generated/run-tests19-write.html
html5lib/generated/run-ruby-data.html
html5lib/generated/run-tests25-data.html
html5lib/generated/run-tests19-data.html

[Build Bot]

Created attachment 263641 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 263635 [details]
Patch

Attachment 263635 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/313686

New failing tests:
fast/css/bidi-override-in-anonymous-block.html
html5lib/generated/run-tests25-write.html
html5lib/generated/run-ruby-write.html
html5lib/generated/run-tests19-write.html
html5lib/generated/run-ruby-data.html
html5lib/generated/run-tests25-data.html
html5lib/generated/run-tests19-data.html

[Build Bot]

Created attachment 263642 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Ryosuke Niwa]

I'm not sure if we want to change the interface of rb. WHATWG spec is "wrong" in that we would want to keep supporting rb in the parser for compatibility reasons.

[Chris Dumez]

Created attachment 263656 [details]
Patch

[Build Bot]

Comment on attachment 263656 [details]
Patch

Attachment 263656 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/314531

New failing tests:
html5lib/generated/run-tests25-write.html
html5lib/generated/run-tests19-write.html
html5lib/generated/run-tests25-data.html
html5lib/generated/run-tests19-data.html

[Build Bot]

Created attachment 263658 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263656 [details]
Patch

Attachment 263656 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/314539

New failing tests:
html5lib/generated/run-tests25-write.html
html5lib/generated/run-tests19-write.html
html5lib/generated/run-tests25-data.html
html5lib/generated/run-tests19-data.html

[Build Bot]

Created attachment 263659 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263656 [details]
Patch

Attachment 263656 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/314543

New failing tests:
html5lib/generated/run-tests25-write.html
html5lib/generated/run-tests19-write.html
html5lib/generated/run-tests25-data.html
html5lib/generated/run-tests19-data.html

[Build Bot]

Created attachment 263660 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 263685 [details]
Patch

[Chris Dumez]

Comment on attachment 263685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263685&action=review

> Source/WebCore/html/HTMLTagNames.in:21
> +bgsound interfaceName=HTMLUnknownElement

I chose a more conservative approach, similar to the one used in Blink. Our parser is still aware of bgsound with this change.

[WebKit Commit Bot]

Comment on attachment 263685 [details]
Patch

Clearing flags on attachment: 263685

Committed r191398: <http://trac.webkit.org/changeset/191398>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.