Bug 148853 - embed element without src and type attributes should represent nothing
Summary: embed element without src and type attributes should represent nothing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-04 16:54 PDT by Chris Dumez
Modified: 2015-11-07 22:19 PST (History)
18 users (show)

See Also:


Attachments
WIP Patch (9.51 KB, patch)
2015-11-06 15:39 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (14.17 KB, patch)
2015-11-06 16:21 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-04 16:54:28 PDT
embed element without src and type attributes should represent nothing [1]:

"""
While any of the following conditions are occurring, any plugin instantiated for the element must be removed, and the embed element represents nothing:
- The element has neither a src attribute nor a type attribute.
- The element has a media element ancestor.
- The element has an ancestor object element that is not showing its fallback content.
"""

Currently, WebKit renders such embed.

This is causing the following newly imported W3C tests to fail:
http/tests/w3c/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-01.html 
http/tests/w3c/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html 

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-embed-element
Comment 1 Chris Dumez 2015-09-04 17:14:22 PDT
rdar://problem/22588235
Comment 2 Chris Dumez 2015-11-06 15:39:37 PST
Created attachment 264966 [details]
WIP Patch
Comment 3 Chris Dumez 2015-11-06 16:21:40 PST
Created attachment 264974 [details]
Patch
Comment 4 WebKit Commit Bot 2015-11-07 15:48:06 PST
Comment on attachment 264974 [details]
Patch

Clearing flags on attachment: 264974

Committed r192132: <http://trac.webkit.org/changeset/192132>
Comment 5 WebKit Commit Bot 2015-11-07 15:48:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2015-11-07 22:06:45 PST
(In reply to comment #6)
> It looks like it broke
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Freplaced%2Freplaced-breaking.html

I'll take a look.
Comment 8 Chris Dumez 2015-11-07 22:19:20 PST
(In reply to comment #7)
> (In reply to comment #6)
> > It looks like it broke
> > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> > html#showAllRuns=true&tests=fast%2Freplaced%2Freplaced-breaking.html
> 
> I'll take a look.

It is odd. The test has a slightly different output on ElCapitan/WK1 only.