Bug 148848 - Add a layout test for https://bugs.webkit.org/show_bug.cgi?id=148845
Summary: Add a layout test for https://bugs.webkit.org/show_bug.cgi?id=148845
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-04 16:34 PDT by Said Abou-Hallawa
Modified: 2015-09-29 10:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2015-09-04 17:41 PDT, Said Abou-Hallawa 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-09-04 16:34:59 PDT 
Add the test case attached to https://bugs.webkit.org/show_bug.cgi?id=148845 as LayoutTests/svg/as-image/svg-cached-no-intrinsic-size-draw-canvas.html. Add this test to LayoutTests/TestExpectations and mark it [ Failure ].
Comment 1 Said Abou-Hallawa 2015-09-04 17:41:46 PDT 
Created attachment 260662 [details]
Patch
Comment 2 Darin Adler 2015-09-11 10:27:03 PDT 
Comment on attachment 260662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260662&action=review

> LayoutTests/ChangeLog:8
> +        Add the layout test and mark it as failed in TestExpectations.

Why? That’s not usually how we do these things.
Comment 3 Said Abou-Hallawa 2015-09-27 16:56:21 PDT 
(In reply to comment #2)
> Comment on attachment 260662 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260662&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Add the layout test and mark it as failed in TestExpectations.
> 
> Why? That’s not usually how we do these things.

My purpose of this patch was to submit the test case even if I do not have the fix ready. For me usually writing the test usually takes more time than fixing the code. 
But I agree I should not do thing differently. So I am closing this bug as WONTFIX. Fixing the other bug  https://bugs.webkit.org/show_bug.cgi?id=148845 should include both the fix and the test case.