Bug 148814 – break-after: column is not supported

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ryosuke Niwa]

See http://www.w3.org/TR/css3-multicol/#break-after

LayoutTests/imported/w3c/css/css-multicol-1/multicol-break-000.xht fails because of this.

[Radar WebKit Bug Importer]

<rdar://problem/22582578>

[Ryosuke Niwa]

imported/w3c/css/css-multicol-1/multicol-break-001.xht also fails due to the lack of support of break-before: column.

[Dave Hyatt]

multicol-break-001.xht is an invalid test. It assumes that a break position can occur between the multicolumn parent and its first child, but this violates the spec, which states that breaks should only occur between siblings.

[Dave Hyatt]

Created attachment 270217 [details]
Patch

[Dave Hyatt]

Created attachment 270220 [details]
Patch

[Dave Hyatt]

Created attachment 270221 [details]
Patch

[WebKit Commit Bot]

Attachment 270221 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSPrimitiveValueMappings.h:2286:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:481:  The parameter name "between" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 270221 [details]
Patch

Attachment 270221 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/756098

New failing tests:
fast/css/style-enumerate-properties.html

[Build Bot]

Created attachment 270224 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Dave Hyatt]

Created attachment 270225 [details]
Patch

[Morten Stenshorne]

Comment on attachment 270225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270225&action=review

Not a complete review or anything. Just stumbled across one thing.

> Source/WebCore/rendering/RenderBlock.cpp:3537
> +        || (checkColumnBreaks && child.style().breakInside() == AvoidColumnBreakInside)

Shouldn't you check for AvoidBreakInside as well?
(also in checkPageBreaks and checkRegionBreaks)

[Dave Hyatt]

Comment on attachment 270225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270225&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3536
> +    return child.isUnsplittableForPagination() || child.style().breakInside() == AvoidBreakInside

It's checked on this line above.

[Dean Jackson]

Comment on attachment 270225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270225&action=review

We should add these new values to the inspector completion list too.

> Source/WebCore/rendering/RenderBlockFlow.cpp:1495
> +    bool checkBeforeAlways = (checkColumnBreaks && child.style().breakBefore() == ColumnBreakBetween)
> +        || (checkPageBreaks && alwaysPageBreak(child.style().breakBefore()))
> +        || (checkRegionBreaks && child.style().breakBefore() == RegionBreakBetween);

I wonder if we should have "auto childBreakBeforeStyle = child.style().breakBefore();" although it isn't really any shorter.

[Dave Hyatt]

Landed in r195892. I'll file a followup bug to do the Web Inspector work.