See http://www.w3.org/TR/css3-multicol/#break-after LayoutTests/imported/w3c/css/css-multicol-1/multicol-break-000.xht fails because of this.
<rdar://problem/22582578>
imported/w3c/css/css-multicol-1/multicol-break-001.xht also fails due to the lack of support of break-before: column.
multicol-break-001.xht is an invalid test. It assumes that a break position can occur between the multicolumn parent and its first child, but this violates the spec, which states that breaks should only occur between siblings.
Created attachment 270217 [details] Patch
Created attachment 270220 [details] Patch
Created attachment 270221 [details] Patch
Attachment 270221 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSPrimitiveValueMappings.h:2286: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:481: The parameter name "between" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 270221 [details] Patch Attachment 270221 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/756098 New failing tests: fast/css/style-enumerate-properties.html
Created attachment 270224 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 270225 [details] Patch
Comment on attachment 270225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270225&action=review Not a complete review or anything. Just stumbled across one thing. > Source/WebCore/rendering/RenderBlock.cpp:3537 > + || (checkColumnBreaks && child.style().breakInside() == AvoidColumnBreakInside) Shouldn't you check for AvoidBreakInside as well? (also in checkPageBreaks and checkRegionBreaks)
Comment on attachment 270225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270225&action=review > Source/WebCore/rendering/RenderBlock.cpp:3536 > + return child.isUnsplittableForPagination() || child.style().breakInside() == AvoidBreakInside It's checked on this line above.
Comment on attachment 270225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270225&action=review We should add these new values to the inspector completion list too. > Source/WebCore/rendering/RenderBlockFlow.cpp:1495 > + bool checkBeforeAlways = (checkColumnBreaks && child.style().breakBefore() == ColumnBreakBetween) > + || (checkPageBreaks && alwaysPageBreak(child.style().breakBefore())) > + || (checkRegionBreaks && child.style().breakBefore() == RegionBreakBetween); I wonder if we should have "auto childBreakBeforeStyle = child.style().breakBefore();" although it isn't really any shorter.
Landed in r195892. I'll file a followup bug to do the Web Inspector work.