Bug 148809 - swipe-start-hysteresis-failures is flaky
Summary: swipe-start-hysteresis-failures is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-04 12:00 PDT by Tim Horton
Modified: 2015-09-04 23:54 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.51 KB, patch)
2015-09-04 12:01 PDT, Tim Horton
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-09-04 12:00:52 PDT
swipe-start-hysteresis-failures is flaky
Comment 1 Tim Horton 2015-09-04 12:01:14 PDT
Created attachment 260606 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-09-04 12:03:08 PDT
Comment on attachment 260606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260606&action=review

> LayoutTests/swipe/swipe-start-hysteresis-failures.html:70
> +        shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.")

I don't see this new shouldBe in expected results.
Comment 3 Tim Horton 2015-09-04 12:20:35 PDT
(In reply to comment #2)
> Comment on attachment 260606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260606&action=review
> 
> > LayoutTests/swipe/swipe-start-hysteresis-failures.html:70
> > +        shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.")
> 
> I don't see this new shouldBe in expected results.

Hmm, my shouldBe only logs if it fails. Maybe I should change that.
Comment 5 Tim Horton 2015-09-04 23:54:05 PDT
I did. http://trac.webkit.org/changeset/189370