Bug 148805 - Import new multicolumn layout tests from CSS WG tests
Summary: Import new multicolumn layout tests from CSS WG tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 148806
  Show dependency treegraph
 
Reported: 2015-09-04 10:54 PDT by Ryosuke Niwa
Modified: 2015-09-07 08:13 PDT (History)
7 users (show)

See Also:


Attachments
Imports tests (628.27 KB, patch)
2015-09-04 11:20 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (628.26 KB, patch)
2015-09-04 11:28 PDT, Ryosuke Niwa
rniwa: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-09-04 10:54:52 PDT
Import tests in https://github.com/w3c/csswg-test/tree/master/css-multicol-1
Comment 1 Ryosuke Niwa 2015-09-04 11:20:53 PDT
Created attachment 260602 [details]
Imports tests
Comment 2 Radar WebKit Bug Importer 2015-09-04 11:21:38 PDT
<rdar://problem/22580772>
Comment 3 Chris Dumez 2015-09-04 11:26:35 PDT
Comment on attachment 260602 [details]
Imports tests

r=me if EWS is happy.
Comment 4 Ryosuke Niwa 2015-09-04 11:28:14 PDT
Created attachment 260604 [details]
Patch for landing
Comment 5 Ryosuke Niwa 2015-09-04 11:44:33 PDT
Committed r189364: <http://trac.webkit.org/changeset/189364>
Comment 6 Ryosuke Niwa 2015-09-04 14:14:37 PDT
Committed r189387: <http://trac.webkit.org/changeset/189387>
Comment 7 Alexey Proskuryakov 2015-09-04 23:23:45 PDT
imported/w3c/css/css-multicol-1/multicol-span-all-001.xht fails on Windows. Could you please take a look?

https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r189367%20(53869)/imported/w3c/css/css-multicol-1/multicol-span-all-001-diffs.html
Comment 8 Chris Dumez 2015-09-05 10:46:44 PDT
(In reply to comment #7)
> imported/w3c/css/css-multicol-1/multicol-span-all-001.xht fails on Windows.
> Could you please take a look?
> 
> https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/
> r189367%20(53869)/imported/w3c/css/css-multicol-1/multicol-span-all-001-
> diffs.html

Marked as failing on Windows in <https://trac.webkit.org/r189436>. This is a ref-test with an off-by one pixel issue. The output looks good overall (difficult to tell the difference).
Comment 9 Carlos Alberto Lopez Perez 2015-09-07 08:01:38 PDT
Some of this tests fail on the GTK port. Reported that on bug 148932
Comment 10 Carlos Alberto Lopez Perez 2015-09-07 08:13:55 PDT
(In reply to comment #9)
> Some of this tests fail on the GTK port. Reported that on bug 148932

Sorry, I got wrong the bug number.

I reported this on bug 148933