Bug 148791 - Implement the division and modulo instructions in WebAssembly
Summary: Implement the division and modulo instructions in WebAssembly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 148772
Blocks: 146064
  Show dependency treegraph
 
Reported: 2015-09-04 02:19 PDT by Sukolsak Sakshuwong
Modified: 2015-09-04 17:14 PDT (History)
8 users (show)

See Also:


Attachments
Patch (13.77 KB, patch)
2015-09-04 02:37 PDT, Sukolsak Sakshuwong
ggaren: review+
Details | Formatted Diff | Diff
Patch (14.08 KB, patch)
2015-09-04 16:14 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-04 02:19:13 PDT
Implement the division and modulo instructions for WebAssembly files generated by pack-asmjs <https://github.com/WebAssembly/polyfill-prototype-1>.
Comment 1 Sukolsak Sakshuwong 2015-09-04 02:37:42 PDT
Created attachment 260580 [details]
Patch
Comment 2 Geoffrey Garen 2015-09-04 13:55:08 PDT
Comment on attachment 260580 [details]
Patch

r=me

I believe you should be able to do an inline div on armvs7 and arm64 as well.
Comment 3 Sukolsak Sakshuwong 2015-09-04 16:14:23 PDT
Created attachment 260641 [details]
Patch

Update to ToT and add the following line to WASMFunctionCompiler::buildBinaryI32() (division instructions): "// FIXME: We should be able to do an inline div on ARMv7 and ARM64."
Comment 4 WebKit Commit Bot 2015-09-04 16:16:52 PDT
Attachment 260641 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:333:  JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2015-09-04 16:26:06 PDT
Comment on attachment 260641 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2015-09-04 17:14:28 PDT
Comment on attachment 260641 [details]
Patch

Clearing flags on attachment: 260641

Committed r189405: <http://trac.webkit.org/changeset/189405>
Comment 7 WebKit Commit Bot 2015-09-04 17:14:32 PDT
All reviewed patches have been landed.  Closing bug.