* SUMMARY Test RuntimeAgent.parse, detecting if a script parse error is recoverable. Make unterminated literal detection more consistent for numeric literals.
<rdar://problem/22574076>
Created attachment 260578 [details] [PATCH] Proposed Fix
Comment on attachment 260578 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=260578&action=review > LayoutTests/inspector/runtime/parse.html:73 > + testSource("`"); // template string > + testSource("`${1}"); // template string Perhaps template strings (and multi-line comments) should be treated as Recoverable. This would allow us to type multi-line comments and template strings in the console (and jsc) more easily. Thoughts?
(In reply to comment #3) > Comment on attachment 260578 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260578&action=review > > > LayoutTests/inspector/runtime/parse.html:73 > > + testSource("`"); // template string > > + testSource("`${1}"); // template string > > Perhaps template strings (and multi-line comments) should be treated as > Recoverable. This would allow us to type multi-line comments and template > strings in the console (and jsc) more easily. Thoughts? I think it would make sense to allow multi-line in these cases.
Created attachment 260603 [details] [PATCH] Proposed Fix
> > Perhaps template strings (and multi-line comments) should be treated as > > Recoverable. This would allow us to type multi-line comments and template > > strings in the console (and jsc) more easily. Thoughts? > > I think it would make sense to allow multi-line in these cases. Done!
Comment on attachment 260603 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260603 Committed r189371: <http://trac.webkit.org/changeset/189371>
All reviewed patches have been landed. Closing bug.