Bug 148790 – Web Inspector: Test RuntimeAgent.parse, detecting if a script parse error is recoverable

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Test RuntimeAgent.parse, detecting if a script parse error is recoverable.

Make unterminated literal detection more consistent for numeric literals.

[Radar WebKit Bug Importer]

<rdar://problem/22574076>

[Joseph Pecoraro]

Created attachment 260578 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 260578 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=260578&action=review

> LayoutTests/inspector/runtime/parse.html:73
> +            testSource("`");     // template string
> +            testSource("`${1}"); // template string

Perhaps template strings (and multi-line comments) should be treated as Recoverable. This would allow us to type multi-line comments and template strings in the console (and jsc) more easily. Thoughts?

[Timothy Hatcher]

(In reply to comment #3)
> Comment on attachment 260578 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260578&action=review
> 
> > LayoutTests/inspector/runtime/parse.html:73
> > +            testSource("`");     // template string
> > +            testSource("`${1}"); // template string
> 
> Perhaps template strings (and multi-line comments) should be treated as
> Recoverable. This would allow us to type multi-line comments and template
> strings in the console (and jsc) more easily. Thoughts?

I think it would make sense to allow multi-line in these cases.

[Joseph Pecoraro]

Created attachment 260603 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

> > Perhaps template strings (and multi-line comments) should be treated as
> > Recoverable. This would allow us to type multi-line comments and template
> > strings in the console (and jsc) more easily. Thoughts?
> 
> I think it would make sense to allow multi-line in these cases.

Done!

[WebKit Commit Bot]

Comment on attachment 260603 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260603

Committed r189371: <http://trac.webkit.org/changeset/189371>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.