* SUMMARY Add tests for DOM highlight commands. DOM.highlightRect DOM.highlightQuad DOM.highlightNode DOM.highlightFrame DOM.highlightSelector DOM.hideHighlight There was already a test for highlightSelector, I will port that to the new test suite approach. Writing tests caught a few issues, including one affecting highlightQuad/Rect when using usePageCoordinates.
<rdar://problem/22572509>
Created attachment 260565 [details] [PATCH] Proposed Fix
Comment on attachment 260565 [details] [PATCH] Proposed Fix Attachment 260565 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/138726 New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/hideHighlight.html
Created attachment 260567 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 260570 [details] [PATCH] Proposed Fix
Comment on attachment 260570 [details] [PATCH] Proposed Fix Attachment 260570 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/138947 New failing tests: inspector/dom/hideHighlight.html
Created attachment 260573 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 260570 [details] [PATCH] Proposed Fix Attachment 260570 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/138988 New failing tests: swipe/swipe-start-hysteresis-failures.html
Created attachment 260574 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 260613 [details] [PATCH] Proposed Fix Stabilize tests by giving explicit sizes to the targeted and logged elements.
Comment on attachment 260613 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260613 Committed r189416: <http://trac.webkit.org/changeset/189416>
All reviewed patches have been landed. Closing bug.