Bug 148783 - Unify symbolTableGet and Put in JSLexicalEnvironment and JSSymbolTableObject
Summary: Unify symbolTableGet and Put in JSLexicalEnvironment and JSSymbolTableObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-03 21:16 PDT by Yusuke Suzuki
Modified: 2015-09-08 18:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch (23.08 KB, patch)
2015-09-08 16:14 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-09-03 21:16:35 PDT 
They are almost identical.
Comment 1 Yusuke Suzuki 2015-09-08 16:14:30 PDT 
Created attachment 260804 [details]
Patch
Comment 2 Yusuke Suzuki 2015-09-08 16:18:21 PDT 
Comment on attachment 260804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260804&action=review

> Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:-55
> -    slot.setValue(this, DontEnum, result);

The only difference is here. JSLexicalEnvironment::symbolTableGet always produced the slot with DontEnum.
But I don't think it is intentionally used behavior.

> Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:-111
> -inline bool JSLexicalEnvironment::symbolTablePutWithAttributes(VM& vm, PropertyName propertyName, JSValue value, unsigned attributes)

Not used.
Comment 3 Geoffrey Garen 2015-09-08 17:14:43 PDT 
Comment on attachment 260804 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2015-09-08 17:22:19 PDT 
Comment on attachment 260804 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2015-09-08 18:33:01 PDT 
Comment on attachment 260804 [details]
Patch

Clearing flags on attachment: 260804

Committed r189525: <http://trac.webkit.org/changeset/189525>
Comment 6 WebKit Commit Bot 2015-09-08 18:33:04 PDT 
All reviewed patches have been landed.  Closing bug.