*** Bug 153441 has been marked as a duplicate of this bug. ***
Created attachment 282105 [details]
*** Bug 159270 has been marked as a duplicate of this bug. ***
Comment on attachment 282105 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=282105&action=review
r=me with comments
> + // The ES6 spec says that just no RestrictedGlobalProperty can't be shadowed
Typo: remove the "no".
> + sentinel = "bad";
Please add an assertion that globalProperty is configurable.
> + load("./multiple-files-tests/global-lexical-redeclare-variable/seventh.js");
Ditto for Array
> + load("./multiple-files-tests/global-lexical-redeclare-variable/nineth.js");
Typo: should be "ninth"
Created attachment 282507 [details]
Comment on attachment 282507 [details]
Rejecting attachment 282507 [details] from review queue.
firstname.lastname@example.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
(In reply to comment #4)
> Comment on attachment 282105 [details]
> View in context:
> r=me with comments
> > + // The ES6 spec says that just no RestrictedGlobalProperty can't be shadowed
> Typo: remove the "no".
> > + sentinel = "bad";
> Please add an assertion that globalProperty is configurable.
How can I do this assertion?
Created attachment 282518 [details]
Comment on attachment 282518 [details]
Clearing flags on attachment: 282518
Committed r202734: <http://trac.webkit.org/changeset/202734>
All reviewed patches have been landed. Closing bug.