Documented here: http://www.ecma-international.org/ecma-262/6.0/index.html#sec-hasrestrictedglobalproperty
*** Bug 153441 has been marked as a duplicate of this bug. ***
Created attachment 282105 [details] Patch
*** Bug 159270 has been marked as a duplicate of this bug. ***
Comment on attachment 282105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282105&action=review r=me with comments > Source/JavaScriptCore/runtime/Executable.cpp:609 > + // The ES6 spec says that just no RestrictedGlobalProperty can't be shadowed Typo: remove the "no". > Source/JavaScriptCore/tests/stress/global-lexical-redeclare-variable.js:71 > + sentinel = "bad"; Please add an assertion that globalProperty is configurable. > Source/JavaScriptCore/tests/stress/global-lexical-redeclare-variable.js:80 > + load("./multiple-files-tests/global-lexical-redeclare-variable/seventh.js"); Ditto for Array > Source/JavaScriptCore/tests/stress/global-lexical-redeclare-variable.js:97 > + load("./multiple-files-tests/global-lexical-redeclare-variable/nineth.js"); Typo: should be "ninth"
Created attachment 282507 [details] Patch
Comment on attachment 282507 [details] Patch Rejecting attachment 282507 [details] from review queue. ticaiolima@gmail.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
(In reply to comment #4) > Comment on attachment 282105 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282105&action=review > > r=me with comments > > > Source/JavaScriptCore/runtime/Executable.cpp:609 > > + // The ES6 spec says that just no RestrictedGlobalProperty can't be shadowed > > Typo: remove the "no". > > > Source/JavaScriptCore/tests/stress/global-lexical-redeclare-variable.js:71 > > + sentinel = "bad"; > > Please add an assertion that globalProperty is configurable. How can I do this assertion?
Created attachment 282518 [details] Patch
Comment on attachment 282518 [details] Patch Clearing flags on attachment: 282518 Committed r202734: <http://trac.webkit.org/changeset/202734>
All reviewed patches have been landed. Closing bug.