Bug 148760 - [EFL] Make it enable to attach gdb to WebKitTestRunner from the launching of the UIProcess
Summary: [EFL] Make it enable to attach gdb to WebKitTestRunner from the launching of ...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joonghun Park
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-03 17:09 PDT by Joonghun Park
Modified: 2017-03-11 10:36 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.71 KB, patch)
2015-09-03 17:12 PDT, Joonghun Park
no flags Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2015-09-03 19:15 PDT, Joonghun Park
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (690.26 KB, application/zip)
2015-09-03 19:32 PDT, Build Bot
no flags Details
Patch (2.52 KB, patch)
2015-09-03 20:42 PDT, Joonghun Park
no flags Details | Formatted Diff | Diff
Use mkdtemp instead of mktemp (2.47 KB, patch)
2015-09-05 06:15 PDT, Joonghun Park
ossy: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joonghun Park 2015-09-03 17:09:15 PDT
Currently when trying to execute WebKitTestRunner by executable file name itself, it leads to crash
because "DUMPRENDERTREE_TEMP" env is only set in _start of xvfbdriver.py, which means only run-webkit-tests set the envs for now.

This patch enables gdb to be attached to WebKitTestRunner from the launching of the UIProcess by executing the command as below.
TEST_RUNNER_PLUGIN_PATH= TEST_RUNNER_INJECTED_BUNDLE_FILENAME=WebKitBuild/Debug/lib/libTestRunnerInjectedBundle.so \
gdb ./WebKitBuild/Debug/bin/WebKitTestRunner
Comment 1 Joonghun Park 2015-09-03 17:12:43 PDT
Created attachment 260540 [details]
Patch
Comment 2 Joonghun Park 2015-09-03 19:15:10 PDT
Created attachment 260551 [details]
Patch
Comment 3 Build Bot 2015-09-03 19:32:23 PDT
Comment on attachment 260551 [details]
Patch

Attachment 260551 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/138342

New failing tests:
swipe/swipe-start-hysteresis-failures.html
Comment 4 Build Bot 2015-09-03 19:32:26 PDT
Created attachment 260554 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 5 Joonghun Park 2015-09-03 20:42:47 PDT
Created attachment 260559 [details]
Patch
Comment 6 Joonghun Park 2015-09-05 06:15:27 PDT
Created attachment 260683 [details]
Use mkdtemp instead of mktemp
Comment 7 Csaba Osztrogonác 2015-09-07 05:06:42 PDT
Comment on attachment 260683 [details]
Use mkdtemp instead of mktemp

I don't think if we should touch TestController::platformLibraryPathForTesting() to fix this issue.

I would prefer a simple script which uses setup_environ_for_server from 
efl.py to set all necessary environment variables to run any test.

We could extend Tools/Scripts/debug-test-runner script which is Mac only now.
Comment 8 Joonghun Park 2015-09-07 16:15:06 PDT
(In reply to comment #7)
> Comment on attachment 260683 [details]
> Use mkdtemp instead of mktemp
> 
> I don't think if we should touch
> TestController::platformLibraryPathForTesting() to fix this issue.
> 
> I would prefer a simple script which uses setup_environ_for_server from 
> efl.py to set all necessary environment variables to run any test.
> 
> We could extend Tools/Scripts/debug-test-runner script which is Mac only now.

Thank you for your review :) I'll check the debug-test-runner script and if it's possible to extend that for EFL port soon enough.
Comment 9 Csaba Osztrogonác 2015-09-08 02:01:25 PDT
(In reply to comment #8)
> Thank you for your review :) I'll check the debug-test-runner script and if
> it's possible to extend that for EFL port soon enough.

As I said debug-test-runner is Apple Mac only script 
now. I meant something similar to run-minibrowser.

Just put the actual code of debug-test-runner to an isAppleMacWebKit() if block
and implement the EFL(and maybe GTK) specific part inside an isEfl()/isGtk().

Maybe we will need a python script to be able set environment variables
for the test runner via efl.py / gtk.py. Additionally these port classes
now the exact path of WebKitTestRunner too. (_path_to_driver)
Comment 10 Michael Catanzaro 2017-03-11 10:36:44 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.